Add fullgc sub-command to allocationprofile

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 #include "vm/compiler.h"
@@ skipping 1443 matching lines @@
 }
 
 
 static bool HandleAllocationProfile(Isolate* isolate, JSONStream* js) {
   if (js->num_arguments() == 2) {
     const char* sub_command = js->GetArgument(1);
     if (!strcmp(sub_command, "reset")) {
       isolate->class_table()->ResetAllocationAccumulators();
       isolate->class_table()->AllocationProfilePrintToJSONStream(js);
       return true;
+    } else if (!strcmp(sub_command, "fullgc")) {

[Ivan Posva, 2014/03/25 21:20:43]

We need a better way to pass parameters to  the different service invocations.
Not in this CL.

[turnidge, 2014/03/25 22:02:50]

This feels more like an option than a subcommand to me:

/isolates/foo/allocationprofile?gc=true

Do you agree?

+      isolate->heap()->CollectAllGarbage();
+      isolate->class_table()->AllocationProfilePrintToJSONStream(js);
+      return true;
     } else {
       PrintError(js, "Unrecognized subcommand '%s'", sub_command);
       return true;
     }
   }
   if (js->num_arguments() != 1) {
     PrintError(js, "Command too long");
     return true;
   }
   isolate->class_table()->AllocationProfilePrintToJSONStream(js);
@@ skipping 402 matching lines @@
   while (current != NULL) {
     if (strcmp(name, current->name()) == 0) {
       return current;
     }
     current = current->next();
   }
   return NULL;
 }
 
 }  // namespace dart