Issue 21067002: Simplify allocation stub for closures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21067002: Simplify allocation stub for closures. (Closed)

Created:
7 years, 4 months ago by Florian Schneider

Modified:
7 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Simplify allocation stub for closures. The compiler never generates code for allocating implicit static closures using the allocation stub. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25573

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -148 lines)			Patch
M	runtime/vm/code_generator.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	4 chunks	+21 lines, -32 lines	1 comment	Download
M	runtime/vm/stub_code_ia32.cc	View	4 chunks	+20 lines, -31 lines	1 comment	Download
M	runtime/vm/stub_code_mips.cc	View	4 chunks	+21 lines, -37 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	4 chunks	+20 lines, -31 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/21067002/diff/1/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/21067002/diff/1/runtime/vm/stub_code_arm.cc#newcode981 runtime/vm/stub_code_arm.cc:981: cls.type_arguments_field_offset() != Class::kNoTypeArguments); Add parentheses https://codereview.chromium.org/21067002/diff/1/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc ...

7 years, 4 months ago (2013-07-29 16:23:15 UTC) #2

Florian Schneider

7 years, 4 months ago (2013-07-29 16:56:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25573 (presubmit successful).

Expand Messages | Collapse Messages