Simplify allocation stub for closures.

runtime/vm/stub_code_mips.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_MIPS)
 
 #include "vm/assembler.h"
 #include "vm/code_generator.h"
 #include "vm/compiler.h"
@@ skipping 1108 matching lines @@
 
 // Called for inline allocation of objects.
 // Input parameters:
 //   RA : return address.
 //   SP + 4 : type arguments object (only if class is parameterized).
 //   SP + 0 : type arguments of instantiator (only if class is parameterized).
 void StubCode::GenerateAllocationStubForClass(Assembler* assembler,
                                               const Class& cls) {
   __ TraceSimMsg("AllocationStubForClass");
   // The generated code is different if the class is parameterized.
-  const bool is_cls_parameterized =
-      cls.type_arguments_field_offset() != Class::kNoTypeArguments;
+  const bool is_cls_parameterized = cls.HasTypeArguments();
+  ASSERT(!cls.HasTypeArguments() ||
+         cls.type_arguments_field_offset() != Class::kNoTypeArguments);
   // kInlineInstanceSize is a constant used as a threshold for determining
   // when the object initialization should be done as a loop or as
   // straight line code.
   const int kInlineInstanceSize = 12;
   const intptr_t instance_size = cls.instance_size();
   ASSERT(instance_size > 0);
   const intptr_t type_args_size = InstantiatedTypeArguments::InstanceSize();
   if (FLAG_inline_alloc &&
       Heap::IsAllocatableInNewSpace(instance_size + type_args_size)) {
     Label slow_case;
@@ skipping 152 matching lines @@
 
 
 // Called for inline allocation of closures.
 // Input parameters:
 //   RA: return address.
 //   SP + 4 : receiver (null if not an implicit instance closure).
 //   SP + 0 : type arguments object (null if class is no parameterized).
 void StubCode::GenerateAllocationStubForClosure(Assembler* assembler,
                                                 const Function& func) {
   ASSERT(func.IsClosureFunction());
-  const bool is_implicit_static_closure =
-      func.IsImplicitStaticClosureFunction();
+  ASSERT(!func.IsImplicitStaticClosureFunction());
   const bool is_implicit_instance_closure =
       func.IsImplicitInstanceClosureFunction();
   const Class& cls = Class::ZoneHandle(func.signature_class());
   const bool has_type_arguments = cls.HasTypeArguments();
 
   __ TraceSimMsg("AllocationStubForClosure");
   __ EnterStubFrame(true);  // Uses pool pointer to refer to function.
   const intptr_t kTypeArgumentsFPOffset = 3 * kWordSize;
   const intptr_t kReceiverFPOffset = 4 * kWordSize;
   const intptr_t closure_size = Closure::InstanceSize();
@@ skipping 34 matching lines @@
     __ LoadImmediate(T0, tags);
     __ sw(T0, Address(T2, Instance::tags_offset()));
 
     // Initialize the function field in the object.
     // T2: new closure object.
     // T4: new context object (only if is_implicit_closure).
     __ LoadObject(T0, func);  // Load function of closure to be allocated.
     __ sw(T0, Address(T2, Closure::function_offset()));
 
     // Setup the context for this closure.
-    if (is_implicit_static_closure) {
-      ObjectStore* object_store = Isolate::Current()->object_store();
-      ASSERT(object_store != NULL);
-      const Context& empty_context =
-          Context::ZoneHandle(object_store->empty_context());
-      __ LoadObject(T0, empty_context);
-      __ sw(T0, Address(T0, Closure::context_offset()));
-    } else if (is_implicit_instance_closure) {
+    if (is_implicit_instance_closure) {
       // Initialize the new context capturing the receiver.
       const Class& context_class = Class::ZoneHandle(Object::context_class());
       // Set the tags.
       uword tags = 0;
       tags = RawObject::SizeTag::update(context_size, tags);
       tags = RawObject::ClassIdTag::update(context_class.id(), tags);
       __ LoadImmediate(T0, tags);
       __ sw(T0, Address(T4, Context::tags_offset()));
 
       // Set number of variables field to 1 (for captured receiver).
@@ skipping 25 matching lines @@
 
     // Done allocating and initializing the instance.
     // V0: new object.
     __ addiu(V0, T2, Immediate(kHeapObjectTag));
 
     __ LeaveStubFrameAndReturn(RA, true);
 
     __ Bind(&slow_case);
   }
 
-  // If it's an implicit static closure we need 2 stack slots. Otherwise,
   // If it's an implicit instance closure we need 4 stack slots, o/w only 3.
-  int num_slots = 2;
-  if (!is_implicit_static_closure) {
-    num_slots = is_implicit_instance_closure ? 4 : 3;
-  }
+  intptr_t num_slots = is_implicit_instance_closure ? 4 : 3;
   __ addiu(SP, SP, Immediate(-num_slots * kWordSize));
   // Setup space on stack for return value.
   __ LoadImmediate(T7, reinterpret_cast<intptr_t>(Object::null()));
   __ sw(T7, Address(SP, (num_slots - 1) * kWordSize));
   __ LoadObject(TMP1, func);
   __ sw(TMP1, Address(SP, (num_slots - 2) * kWordSize));
-  if (is_implicit_static_closure) {
-    __ CallRuntime(kAllocateImplicitStaticClosureRuntimeEntry);
+  __ mov(T2, T7);
+  if (is_implicit_instance_closure) {
+    __ lw(T1, Address(FP, kReceiverFPOffset));
+    __ sw(T1, Address(SP, (num_slots - 3) * kWordSize));  // Receiver.
+  }
+  if (has_type_arguments) {
+    __ lw(T2, Address(FP, kTypeArgumentsFPOffset));
+  }
+  __ sw(T2, Address(SP, 0 * kWordSize));
+
+  if (is_implicit_instance_closure) {
+    __ CallRuntime(kAllocateImplicitInstanceClosureRuntimeEntry);
     __ TraceSimMsg("AllocationStubForClosure return");
   } else {
-    __ mov(T2, T7);
-    if (is_implicit_instance_closure) {
-      __ lw(T1, Address(FP, kReceiverFPOffset));
-      __ sw(T1, Address(SP, (num_slots - 3) * kWordSize));  // Receiver.
-    }
-    if (has_type_arguments) {
-      __ lw(T2, Address(FP, kTypeArgumentsFPOffset));
-    }
-    __ sw(T2, Address(SP, 0 * kWordSize));
-
-    if (is_implicit_instance_closure) {
-      __ CallRuntime(kAllocateImplicitInstanceClosureRuntimeEntry);
-      __ TraceSimMsg("AllocationStubForClosure return");
-    } else {
-      ASSERT(func.IsNonImplicitClosureFunction());
-      __ CallRuntime(kAllocateClosureRuntimeEntry);
-      __ TraceSimMsg("AllocationStubForClosure return");
-    }
+    ASSERT(func.IsNonImplicitClosureFunction());
+    __ CallRuntime(kAllocateClosureRuntimeEntry);
+    __ TraceSimMsg("AllocationStubForClosure return");
   }
   __ lw(V0, Address(SP, (num_slots - 1) * kWordSize));  // Pop function object.
   __ addiu(SP, SP, Immediate(num_slots * kWordSize));
 
   // V0: new object
   // Restore the frame pointer.
   __ LeaveStubFrameAndReturn(RA, true);
 }
 
 
@@ skipping 924 matching lines @@
   __ lw(left, Address(SP, 1 * kWordSize));
   __ lw(temp2, Address(SP, 2 * kWordSize));
   __ lw(temp1, Address(SP, 3 * kWordSize));
   __ Ret();
   __ delay_slot()->addiu(SP, SP, Immediate(4 * kWordSize));
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_MIPS