Issue 208583003: Fix string literals and add support for static methods in smoke.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208583003: Fix string literals and add support for static methods in smoke. (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix string literals and add support for static methods in smoke. This fixes two issues I noticed while testing things out in polymer: - names should use raw strings, in case identifiers have a $ - static methods were not supported in static.dart R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=34272

Patch Set 1 : #

Patch Set 2 : minor fix - inlcude name for static method too #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -23 lines)			Patch
M	pkg/smoke/lib/codegen/generator.dart	View		3 chunks	+33 lines, -1 line	0 comments	Download
M	pkg/smoke/lib/codegen/recorder.dart	View	1	4 chunks	+14 lines, -3 lines	0 comments	Download
M	pkg/smoke/lib/static.dart	View		5 chunks	+13 lines, -4 lines	0 comments	Download
M	pkg/smoke/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/smoke/test/codegen/end_to_end_test.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/smoke/test/codegen/generator_test.dart	View		4 chunks	+20 lines, -5 lines	0 comments	Download
M	pkg/smoke/test/codegen/recorder_test.dart	View	1	10 chunks	+114 lines, -8 lines	0 comments	Download
M	pkg/smoke/test/common.dart	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	pkg/smoke/test/static_test.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

6 years, 9 months ago (2014-03-21 21:13:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r34272 (presubmit successful).

Expand Messages | Collapse Messages