Fix string literals and add support for static methods in smoke.

pkg/smoke/lib/static.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Static implementation of smoke services using code-generated data.
 library smoke.static;
 
 import 'dart:math' as math;
 
 import 'package:logging/logging.dart';
 import 'package:smoke/smoke.dart';
 
 import 'src/common.dart';
 
 typedef T Getter<T>(object);
 typedef void Setter<T>(object, value);
 
 class StaticConfiguration {
   /// Maps symbol to a function that reads that symbol of an object. For
   /// instance, `#i: (o) => o.i`.
   final Map<Symbol, Getter> getters;
 
   /// Maps symbol to a function that updates that symbol of an object. For
   /// instance, `#i: (o, v) { o.i = v; }`.
   final Map<Symbol, Setter> setters;
 
-  /// Maps a type to it's super class. For example, String: Object.
+  /// Maps a type to its super class. For example, String: Object.
   final Map<Type, Type> parents;
 
   /// For each type, a map of declarations per symbol (property or method).
   final Map<Type, Map<Symbol, Declaration>> declarations;
 
+  /// Static methods for each type.
+  // TODO(sigmund): should we add static getters & setters too?
+  final Map<Type, Map<Symbol, Function>> staticMethods;
+
   /// A map from symbol to strings.
   final Map<Symbol, String> names;
 
   /// Whether to check for missing declarations, otherwise, return default
   /// values (for example a missing parent class can be treated as Object)
   final bool checkedMode;
 
   StaticConfiguration({
       this.getters: const {}, this.setters: const {}, this.parents: const {},
-      this.declarations: const {}, this.names: const {},
-      this.checkedMode: true});
+      this.declarations: const {}, this.staticMethods: const {},
+      this.names: const {}, this.checkedMode: true});
 }
 
 /// Set up the smoke package to use a static implementation based on the given
 /// [configuration].
 useGeneratedCode(StaticConfiguration configuration) {
   configure(new GeneratedObjectAccessorService(configuration),
       new GeneratedTypeInspectorService(configuration),
       new GeneratedSymbolConverterService(configuration));
 }
 
 /// Implements [ObjectAccessorService] using a static configuration.
 class GeneratedObjectAccessorService implements ObjectAccessorService {
   final Map<Symbol, Getter> _getters;
   final Map<Symbol, Setter> _setters;
+  final Map<Type, Map<Symbol, Function>> _staticMethods;
 
   GeneratedObjectAccessorService(StaticConfiguration configuration)
       : _getters = configuration.getters,
-        _setters = configuration.setters;
+        _setters = configuration.setters,
+        _staticMethods = configuration.staticMethods;
 
   read(Object object, Symbol name) {
     var getter = _getters[name];
     if (getter == null) {
       throw new MissingCodeException('getter "$name" in $object');
     }
     return getter(object);
   }
+
   void write(Object object, Symbol name, value) {
     var setter = _setters[name];
     if (setter == null) {
       throw new MissingCodeException('setter "$name" in $object');
     }
     setter(object, value);
   }
 
   invoke(object, Symbol name, List args, {Map namedArgs, bool adjust: false}) {
     var method;
     if (object is Type) {
+      var classMethods = _staticMethods[object];
+      method = classMethods == null ? null : classMethods[name];
     } else {
       var getter = _getters[name];
       method = getter == null ? null : getter(object);
     }
     if (method == null) {
       throw new MissingCodeException('method "$name" in $object');
     }
     var tentativeError;
     if (adjust) {
       var min = minArgs(method);
@@ skipping 155 matching lines @@
 
 /// Exception thrown when trynig to access something that should be there, but
 /// the code generator didn't include it.
 class MissingCodeException implements Exception {
   final String description;
   MissingCodeException(this.description);
 
   String toString() => 'Missing $description. '
       'Code generation for the smoke package seems incomplete.';
 }