Issue 207373002: Report fail in html_config when fail happens. I believe this was why we were

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207373002: Report fail in html_config when fail happens. I believe this was why we were (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 9 months ago

Reviewers:
Jennifer Messerly, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report fail in html_config when fail happens. I believe this was why we were getting messages that say: "Warning: Test had 'FAIL' and 'PASS' in stdout." R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=34218

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/unittest/lib/html_config.dart	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/207373002/diff/1/pkg/unittest/lib/html_config.dart File pkg/unittest/lib/html_config.dart (right): https://codereview.chromium.org/207373002/diff/1/pkg/unittest/lib/html_config.dart#newcode170 pkg/unittest/lib/html_config.dart:170: success ? 'unittest-suite-done' : 'unittest-suite-fail', '*'); nice! I ...

6 years, 9 months ago (2014-03-21 00:27:50 UTC) #2

Siggi Cherem (dart-lang)

Committed patchset #1 manually as r34218 (presubmit successful).

6 years, 9 months ago (2014-03-21 00:30:01 UTC) #3

Jennifer Messerly

6 years, 9 months ago (2014-03-21 01:02:35 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/207373002/diff/1/pkg/unittest/lib/html_config...
File pkg/unittest/lib/html_config.dart (right):

https://codereview.chromium.org/207373002/diff/1/pkg/unittest/lib/html_config...
pkg/unittest/lib/html_config.dart:170: success ? 'unittest-suite-done' :
'unittest-suite-fail', '*');
On 2014/03/21 00:27:50, John Messerly wrote:
> nice! I hit this same line a while back. Didn't fix it at the time for reasons
I
> can't recall. But definitely better than the current logic that prints PASS
and
> FAIL...

Aha, here's the history behind this :)
https://codereview.chromium.org/75393002/

Expand Messages | Collapse Messages