pkg/unittest/lib/html_config.dart - Issue 207373002: Report fail in html_config when fail happens. I believe this was why we were

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/unittest/lib/html_config.dart

Issue 207373002: Report fail in html_config when fail happens. I believe this was why we were (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/unittest/lib/html_config.dart

diff --git a/pkg/unittest/lib/html_config.dart b/pkg/unittest/lib/html_config.dart

index ef23d52da4b79e81d11841133d84c93b3603ffa1..67de52021bd22f0d95cc749656f38c1a39994c01 100644

--- a/pkg/unittest/lib/html_config.dart

+++ b/pkg/unittest/lib/html_config.dart

@@ -166,7 +166,8 @@ class HtmlConfiguration extends SimpleConfiguration {

void onDone(bool success) {

_uninstallHandlers();

- window.postMessage('unittest-suite-done', '*');

+ window.postMessage(

+ success ? 'unittest-suite-done' : 'unittest-suite-fail', '*');

Jennifer Messerly 2014/03/21 00:27:50 nice! I hit this same line a while back. Didn't fi

Jennifer Messerly 2014/03/21 01:02:35 Aha, here's the history behind this :) https://cod

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »