Properly map function names with named arguments.

Properly map function names with named arguments.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/source_map_stack_trace/commit/889fea3c1eb6003bac4127225fddadc7d2509f09

[nweiz, 2016-06-15 19:08:23]

nweiz@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-06-15 19:26:10]

lgtm

https://codereview.chromium.org/2069043004/diff/1/lib/source_map_stack_trace....
File lib/source_map_stack_trace.dart (left):

https://codereview.chromium.org/2069043004/diff/1/lib/source_map_stack_trace....
lib/source_map_stack_trace.dart:84: return member
Orthogonal: How often is this method called? During anything perf-critical?

Creating all of the RegExp instances on every call could cause a lot of unneeded
GC churn. Just curious...

[nweiz, 2016-06-15 20:29:09]

https://codereview.chromium.org/2069043004/diff/1/lib/source_map_stack_trace....
File lib/source_map_stack_trace.dart (left):

https://codereview.chromium.org/2069043004/diff/1/lib/source_map_stack_trace....
lib/source_map_stack_trace.dart:84: return member
On 2016/06/15 19:26:10, kevmoo wrote:
> Orthogonal: How often is this method called? During anything perf-critical?
> 
> Creating all of the RegExp instances on every call could cause a lot of
unneeded
> GC churn. Just curious...

For now I don't think it's being used anywhere performance-critical. If it
starts showing up in the profiler, we can optimize it then.

[nweiz, 2016-06-15 20:29:51]

Description was changed from

==========
Properly map function names with named arguments.
==========

to

==========
Properly map function names with named arguments.

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/source_map_stack_trace/commit/889fea3c1eb6003bac...
==========

[nweiz, 2016-06-15 20:29:52]

Committed patchset #1 (id:1) manually as
889fea3c1eb6003bac4127225fddadc7d2509f09 (presubmit successful).