lib/source_map_stack_trace.dart - Issue 2069043004: Properly map function names with named arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/source_map_stack_trace.dart

Issue 2069043004: Properly map function names with named arguments. (Closed) Base URL: git@github.com:dart-lang/source_map_stack_trace.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/source_map_stack_trace.dart

diff --git a/lib/source_map_stack_trace.dart b/lib/source_map_stack_trace.dart

index 23aed777433d516faaffe16e50e5b0c110aeb4c1..83bbf64775043ba2e67c05d45430573868fc0dfe 100644

--- a/lib/source_map_stack_trace.dart

+++ b/lib/source_map_stack_trace.dart

@@ -84,8 +84,8 @@ String _prettifyMember(String member) {

return member

kevmoo 2016/06/15 19:26:10 Orthogonal: How often is this method called? Durin

nweiz 2016/06/15 20:29:09 For now I don't think it's being used anywhere per

// Get rid of the noise that Firefox sometimes adds.

.replaceAll(new RegExp(r"/?<$"), "")

- // Get rid of arity indicators.

- .replaceAll(new RegExp(r"\$\d+$"), "")

+ // Get rid of arity indicators and named arguments.

+ .replaceAll(new RegExp(r"\$\d+(\$[a-zA-Z_0-9]+)*$"), "")

// Convert closures to <fn>.

.replaceAllMapped(new RegExp(r"(_+)closure\d*\.call$"),

// The number of underscores before "closure" indicates how nested it

« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »