Issue 20575003: Fix for issue 12136 (do not try to copy type arguments if the base class

Issue 20575003: Fix for issue 12136 (do not try to copy type arguments if the base class (Closed)

Created:
7 years, 4 months ago by siva

Modified:
7 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 12136 (do not try to copy type arguments if the base class has no type arguments). R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25688

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -16 lines)			Patch
	M	runtime/vm/debugger_api_impl.cc	View	1 2	2 chunks	+20 lines, -14 lines	0 comments	Download
	M	runtime/vm/debugger_api_impl_test.cc	View		4 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM if you add one check. https://chromiumcodereview.appspot.com/20575003/diff/6001/runtime/vm/debugger_api_impl.cc File runtime/vm/debugger_api_impl.cc (right): https://chromiumcodereview.appspot.com/20575003/diff/6001/runtime/vm/debugger_api_impl.cc#newcode529 runtime/vm/debugger_api_impl.cc:529: } You also ...

7 years, 4 months ago (2013-07-31 23:11:59 UTC) #3

siva

https://chromiumcodereview.appspot.com/20575003/diff/6001/runtime/vm/debugger_api_impl.cc File runtime/vm/debugger_api_impl.cc (right): https://chromiumcodereview.appspot.com/20575003/diff/6001/runtime/vm/debugger_api_impl.cc#newcode529 runtime/vm/debugger_api_impl.cc:529: } On 2013/07/31 23:11:59, regis wrote: > You also ...

7 years, 4 months ago (2013-07-31 23:24:05 UTC) #4

siva

7 years, 4 months ago (2013-07-31 23:27:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r25688 (presubmit successful).

Expand Messages | Collapse Messages