Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 20575003: Fix for issue 12136 (do not try to copy type arguments if the base class (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_api_impl_test.cc
===================================================================
--- runtime/vm/debugger_api_impl_test.cc (revision 25667)
+++ runtime/vm/debugger_api_impl_test.cc (working copy)
@@ -1462,6 +1462,7 @@
"}\n"
"class Test5<A, B, C> extends Test4<A, B> {\n"
"}\n"
+ "var s = new Set();\n"
"int main() {\n"
"}\n";
@@ -1479,6 +1480,8 @@
Dart_Handle Test5_name = Dart_NewStringFromCString("Test5");
Dart_Handle object_name = Dart_NewStringFromCString("Object");
Dart_Handle int_name = Dart_NewStringFromCString("int");
+ Dart_Handle set_name = Dart_NewStringFromCString("Set");
+ Dart_Handle iterable_name = Dart_NewStringFromCString("IterableBase");
Dart_Handle object_type = Dart_GetType(core_lib, object_name, 0, NULL);
Dart_Handle int_type = Dart_GetType(core_lib, int_name, 0, NULL);
@@ -1494,14 +1497,14 @@
Dart_Handle Test3_type = Dart_GetType(script_lib, Test3_name, 0, NULL);
type_args = Dart_NewList(2);
Dart_ListSetAt(type_args, 0, int_type);
- Dart_ListSetAt(type_args, 1, int_type);
+ Dart_ListSetAt(type_args, 1, Test_type);
Dart_Handle Test4_int_type = Dart_GetType(script_lib,
Test4_name,
2,
&type_args);
type_args = Dart_NewList(3);
Dart_ListSetAt(type_args, 0, int_type);
- Dart_ListSetAt(type_args, 1, int_type);
+ Dart_ListSetAt(type_args, 1, Test_type);
Dart_ListSetAt(type_args, 2, int_type);
Dart_Handle Test5_int_type = Dart_GetType(script_lib,
Test5_name,
@@ -1535,6 +1538,14 @@
const Type& actual_type = Api::UnwrapTypeHandle(isolate, super_type);
EXPECT(expected_type.raw() == actual_type.raw());
}
+ {
+ Dart_Handle set_type = Dart_GetType(core_lib, set_name, 0, NULL);
+ Dart_Handle super_type = Dart_GetSupertype(set_type);
+ Dart_Handle iterable_type = Dart_GetType(core_lib, iterable_name, 0, NULL);
+ const Type& expected_type = Api::UnwrapTypeHandle(isolate, iterable_type);
+ const Type& actual_type = Api::UnwrapTypeHandle(isolate, super_type);
+ EXPECT(expected_type.raw() == actual_type.raw());
+ }
}
} // namespace dart
« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698