Issue 20503003: Delay resolution of redirecting factory targets in order to avoid class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20503003: Delay resolution of redirecting factory targets in order to avoid class (Closed)

Created:
7 years, 5 months ago by regis

Modified:
7 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Delay resolution of redirecting factory targets in order to avoid class finalization cycles (issue 12041). Ensure that a super class is finalized before the class extending it. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25532

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -12 lines)			Patch
M	runtime/vm/class_finalizer.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	6 chunks	+28 lines, -8 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

regis

I think this should solve the issue with cyclic class finalization. We can discuss some ...

7 years, 5 months ago (2013-07-26 03:00:11 UTC) #1

regis

7 years, 5 months ago (2013-07-26 18:19:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25532 (presubmit successful).