runtime/vm/dart_api_impl.cc - Issue 20503003: Delay resolution of redirecting factory targets in order to avoid class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 20503003: Delay resolution of redirecting factory targets in order to avoid class (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

===================================================================

--- runtime/vm/dart_api_impl.cc (revision 25531)

+++ runtime/vm/dart_api_impl.cc (working copy)

@@ -2819,9 +2819,14 @@

Instance& new_object = Instance::Handle(isolate);

if (constructor.IsRedirectingFactory()) {

- Type& type = Type::Handle(constructor.RedirectionType());

+ ClassFinalizer::ResolveRedirectingFactory(cls, constructor);

+ const Type& type = Type::Handle(constructor.RedirectionType());

+ constructor = constructor.RedirectionTarget();

+ if (constructor.IsNull()) {

+ ASSERT(type.IsMalformed());

+ return Api::NewHandle(isolate, type.malformed_error());

+ }

cls = type.type_class();

- constructor = constructor.RedirectionTarget();

}

if (constructor.IsConstructor()) {

// Create the new object.

« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/dart_entry.cc » ('j') | no next file with comments »