Issue 20501005: Corrected MAX_EXACT_INT_TO_DOUBLE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20501005: Corrected MAX_EXACT_INT_TO_DOUBLE. (Closed)

Created:
7 years, 4 months ago by srdjan

Modified:
7 years, 4 months ago

Reviewers:
zra, Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Corrected MAX_EXACT_INT_TO_DOUBLE. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=25725

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/lib/integers.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #1 manually as r25725 (presubmit successful).

7 years, 4 months ago (2013-08-01 23:15:47 UTC) #3

Florian Schneider

7 years, 4 months ago (2013-08-02 11:20:19 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/20501005/diff/1/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/20501005/diff/1/runtime/lib/integers.dart#new...
runtime/lib/integers.dart:102: int MAX_EXACT_INT_TO_DOUBLE = 9007199254740991; 
// 2^53 - 1.
I don't understand why this was not correct: 2^53 is precisely represented as
0x4340000000000000. There is no loss of precision yet.

Expand Messages | Collapse Messages