runtime/lib/integers.dart - Issue 20501005: Corrected MAX_EXACT_INT_TO_DOUBLE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/integers.dart

Issue 20501005: Corrected MAX_EXACT_INT_TO_DOUBLE. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/integers.dart

===================================================================

--- runtime/lib/integers.dart (revision 25710)

+++ runtime/lib/integers.dart (working copy)

@@ -99,7 +99,7 @@

final int EQUAL = 0, LESS = -1, GREATER = 1;

if (other is double) {

// TODO(floitsch): the following locals should be 'const'.

- int MAX_EXACT_INT_TO_DOUBLE = 9007199254740992; // 2^53.

+ int MAX_EXACT_INT_TO_DOUBLE = 9007199254740991; // 2^53 - 1.

Florian Schneider 2013/08/02 11:20:19 I don't understand why this was not correct: 2^53

int MIN_EXACT_INT_TO_DOUBLE = -MAX_EXACT_INT_TO_DOUBLE;

double d = other;

if (d.isInfinite) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »