Issue 20458002: Wrap lazy compilation errors when parsing metadata. Addresses the poor error reporting in issue 120…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20458002: Wrap lazy compilation errors when parsing metadata. Addresses the poor error reporting in issue 120… (Closed)

Created:
7 years, 5 months ago by rmacnak

Modified:
7 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vsm, Jacob, Jennifer Messerly, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Wrap lazy compilation errors when parsing metadata. Addresses the poor error reporting in issue 12027. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25498

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -23 lines)			Patch
	M	runtime/lib/mirrors.cc	View		3 chunks	+27 lines, -23 lines	0 comments	Download
	M	runtime/tests/vm/dart/isolate_mirror_local_test.dart	View	1	2 chunks	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rmacnak

On 2013/07/25 20:35:54, Ryan Macnak wrote: > Adding Peter. test_dart2js.sh passes.

7 years, 5 months ago (2013-07-25 20:49:49 UTC) #4

rmacnak

Committed patchset #2 manually as r25498 (presubmit successful).

7 years, 5 months ago (2013-07-25 20:50:08 UTC) #5

ahe

7 years, 5 months ago (2013-07-26 10:13:03 UTC) #6

Message was sent while issue was closed.

DBC

https://chromiumcodereview.appspot.com/20458002/diff/4001/runtime/tests/vm/da...
File runtime/tests/vm/dart/isolate_mirror_local_test.dart (right):

https://chromiumcodereview.appspot.com/20458002/diff/4001/runtime/tests/vm/da...
runtime/tests/vm/dart/isolate_mirror_local_test.dart:449: Expect.throws(() =>
cls.metadata, (e) => e is MirroredCompilationError, 'Bad metadata');
Long line.

https://chromiumcodereview.appspot.com/20458002/diff/4001/runtime/tests/vm/da...
runtime/tests/vm/dart/isolate_mirror_local_test.dart:451: //
Expect.equals("ClassMirror on 'MyClass'", cls.toString());
I think you can enable this again.

Expand Messages | Collapse Messages