Wrap lazy compilation errors when parsing metadata. Addresses the poor error reporting in issue 120…

runtime/tests/vm/dart/isolate_mirror_local_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for checking implemention of MirrorSystem when
 // inspecting the current isolate.
 //
 // VMOptions=--enable_type_checks
 
 library isolate_mirror_local_test;
@@ skipping 389 matching lines @@
   Expect.equals("InstanceMirror on null", mirror.toString());
   testDone('testNullInstanceMirror');
 }
 
 class MySuperClass {
 }
 
 class MyInterface {
 }
 
+@notDefined
 class MyClass extends MySuperClass implements MyInterface {
   MyClass(this.value) {}
   MyClass.named() {}
 
   final value;
 
   int method(int arg) {
     return arg + value;
   }
 }
@@ skipping 18 matching lines @@
   //               mirror.toString());
 
   ClassMirror cls = mirror.type;
   Expect.isTrue(cls is ClassMirror);
   Expect.equals(const Symbol('MyClass'), cls.simpleName);
   Expect.equals(const Symbol('MySuperClass'), cls.superclass.simpleName);
   Expect.isTrue(cls.defaultFactory == null);
   Expect.equals(const Symbol('isolate_mirror_local_test'), cls.owner.simpleName);
   Expect.isTrue(cls.isClass);
   Expect.equals(const Symbol('MyInterface'), cls.superinterfaces[0].simpleName);
+  Expect.throws(() => cls.metadata, (e) => e is MirroredCompilationError, 'Bad metadata');

[ahe, 2013/07/26 10:13:03]

Long line.

   // TODO(ahe): toString() test disabled for now as Symbols are 100% opaque.
   // Expect.equals("ClassMirror on 'MyClass'", cls.toString());

[ahe, 2013/07/26 10:13:03]

I think you can enable this again.

 
   // Invoke mirror.method(1000).
   mirror.invokeAsync(const Symbol('method'), [ 1000 ]).then(
       (InstanceMirror retval) {
         Expect.equals(const Symbol('int'), retval.type.simpleName);
         Expect.isTrue(retval.hasReflectee);
         Expect.equals(1017, retval.reflectee);
         testDone('testCustomInstanceMirror');
       });
 
@@ skipping 75 matching lines @@
   // Test that an isolate can reflect on itself.
   mirrorSystemOf(exit_port.toSendPort()).then(testMirrorSystem);
 
   testIntegerInstanceMirror(reflect(1001));
   testStringInstanceMirror(reflect('This\nis\na\nString'));
   testBoolInstanceMirror(reflect(true));
   testNullInstanceMirror(reflect(null));
   testCustomInstanceMirror(reflect(new MyClass(17)));
   testMirrorErrors(currentMirrorSystem());
 }