|
These are 3 changes in smoke in preparation of polymer's codegen. I happened to make them at once, but let me know if you prefer that I split them up a bit:
(a) add filter to query. This makes it easier to support *Changed without having to generate metadata about lots of useless methods. We might remove *Changed in the future, but I still think this is a nice feature for smoke.
(b) changed recorder.dart to automatically include getters/setters for queries. It is the most common use case that you query a member because you want both the metadata and to read/write/invoke it.
(c) add a new smoke implementation to make it easier to debug inconsistencies between static vs mirrors implementations. (I used this while debugging stuffin polymer)
R=jmesserly@google.com
Committed: https://code.google.com/p/dart/source/detail?r=34117
Total comments: 3
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+554 lines, -199 lines) |
Patch |
|
M |
pkg/polymer/lib/polymer.dart
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
pkg/polymer/lib/src/declaration.dart
|
View
|
|
3 chunks |
+19 lines, -14 lines |
0 comments
|
Download
|
|
M |
pkg/smoke/lib/codegen/generator.dart
|
View
|
2
|
4 chunks |
+5 lines, -25 lines |
0 comments
|
Download
|
|
M |
pkg/smoke/lib/codegen/recorder.dart
|
View
|
2
|
8 chunks |
+61 lines, -25 lines |
0 comments
|
Download
|
|
M |
pkg/smoke/lib/mirrors.dart
|
View
|
|
2 chunks |
+16 lines, -11 lines |
0 comments
|
Download
|
|
M |
pkg/smoke/lib/smoke.dart
|
View
|
|
4 chunks |
+30 lines, -3 lines |
0 comments
|
Download
|
|
M |
pkg/smoke/lib/src/common.dart
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
M |
pkg/smoke/lib/static.dart
|
View
|
2
|
11 chunks |
+65 lines, -47 lines |
0 comments
|
Download
|
|
A |
pkg/smoke/lib/static_debug.dart
|
View
|
|
1 chunk |
+122 lines, -0 lines |
0 comments
|
Download
|
|
M |
pkg/smoke/pubspec.yaml
|
View
|
1
2
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
pkg/smoke/test/codegen/end_to_end_test.dart
|
View
|
2
|
2 chunks |
+58 lines, -57 lines |
0 comments
|
Download
|
|
M |
pkg/smoke/test/codegen/recorder_test.dart
|
View
|
2
|
17 chunks |
+146 lines, -13 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|