Changes in smoke in preparation of polymer's codegen:

pkg/polymer/lib/src/declaration.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of polymer;
 
 /// *Warning* this class is experimental and subject to change.
 ///
 /// The data associated with a polymer-element declaration, if it is backed
 /// by a Dart class instead of a JavaScript prototype.
@@ skipping 168 matching lines @@
     if (attrs != null) {
       // names='a b c' or names='a,b,c'
       // record each name for publishing
       for (var attr in attrs.split(_ATTRIBUTES_REGEX)) {
         // remove excess ws
         attr = attr.trim();
 
         // do not override explicit entries
         if (attr == '') continue;
 
-        var property = new Symbol(attr);
+        var property = smoke.nameToSymbol(attr);
         var path = new PropertyPath([property]);
         if (_publish != null && _publish.containsKey(path)) {
           continue;
         }
 
         var decl = smoke.getDeclaration(type, property);
         if (decl == null || decl.isMethod || decl.isFinal) {
           window.console.warn('property for attribute $attr of polymer-element '
               'name=$name not found.');
           continue;
@@ skipping 143 matching lines @@
     if (cssText == '') return null;
 
     return new StyleElement()
         ..text = cssText
         ..attributes[_STYLE_SCOPE_ATTRIBUTE] = '$name-$scopeDescriptor';
   }
 
   /// Fetch a list of all *Changed methods so we can observe the associated
   /// properties.
   void inferObservers() {
-    var options = const smoke.QueryOptions(includeFields: false,
-        includeProperties: false, includeMethods: true, includeInherited: true,
-        includeUpTo: HtmlElement);
-    for (var decl in smoke.query(type, options)) {
-      String name = smoke.symbolToName(decl.name);
-      if (name.endsWith(_OBSERVE_SUFFIX) && name != 'attributeChanged') {
-        // TODO(jmesserly): now that we have a better system, should we
-        // deprecate *Changed methods?
-        if (_observe == null) _observe = new HashMap();
-        name = name.substring(0, name.length - 7);
-        _observe[new PropertyPath(name)] = [decl.name];
-      }
+    for (var decl in smoke.query(type, _changedMethodQueryOptions)) {
+      // TODO(jmesserly): now that we have a better system, should we
+      // deprecate *Changed methods?
+      if (_observe == null) _observe = new HashMap();
+      var name = smoke.symbolToName(decl.name);
+      name = name.substring(0, name.length - 7);
+      _observe[new PropertyPath(name)] = [decl.name];
     }
   }
 
   /// Fetch a list of all methods annotated with [ObserveProperty] so we can
   /// observe the associated properties.
   void explodeObservers() {
     var options = const smoke.QueryOptions(includeFields: false,
         includeProperties: false, includeMethods: true, includeInherited: true,
         includeUpTo: HtmlElement, withAnnotations: const [ObserveProperty]);
     for (var decl in smoke.query(type, options)) {
@@ skipping 96 matching lines @@
         .responseText;
   } on DomException catch (e, t) {
     _sheetLog.fine('failed to XHR stylesheet text href="$href" error: '
         '$e, trace: $t');
     return '';
   }
 }
 
 final Logger _sheetLog = new Logger('polymer.stylesheet');
 
-const _OBSERVE_SUFFIX = 'Changed';
+
+final smoke.QueryOptions _changedMethodQueryOptions = new smoke.QueryOptions(
+    includeFields: false, includeProperties: false, includeMethods: true,
+    includeInherited: true, includeUpTo: HtmlElement,
+    matches: _isObserverMethod);
+
+bool _isObserverMethod(Symbol symbol) {
+  String name = smoke.symbolToName(symbol);
+  if (name == null) return false;
+  return name.endsWith('Changed') && name != 'attributeChanged';
+}
 
 // TODO(jmesserly): is this list complete?
 final _eventTranslations = const {
   // TODO(jmesserly): these three Polymer.js translations won't work in Dart,
   // because we strip the webkit prefix (below). Reconcile.
   'webkitanimationstart': 'webkitAnimationStart',
   'webkitanimationend': 'webkitAnimationEnd',
   'webkittransitionend': 'webkitTransitionEnd',
 
   'domfocusout': 'DOMFocusOut',
@@ skipping 24 matching lines @@
 
 // Dart note: we need this function because we have additional renames JS does
 // not have. The JS renames are simply case differences, whereas we have ones
 // like doubleclick -> dblclick and stripping the webkit prefix.
 String _eventNameFromType(String eventType) {
   final result = _reverseEventTranslations[eventType];
   return result != null ? result : eventType;
 }
 
 final _ATTRIBUTES_REGEX = new RegExp(r'\s|,');