Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2039163002: Add SpanScanner.within(). (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/string_scanner@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add SpanScanner.within(). This is useful for doing more detailed parses of sub-sections of larger text. R=rnystrom@google.com Committed: https://github.com/dart-lang/string_scanner/commit/2d44ec8eb90ffa0d7d16048d6ff96702cc27f075

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
A lib/src/relative_span_scanner.dart View 1 1 chunk +112 lines, -0 lines 0 comments Download
M lib/src/span_scanner.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/span_scanner_test.dart View 2 chunks +88 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nweiz
4 years, 6 months ago (2016-06-06 22:13:32 UTC) #2
Bob Nystrom
lgtm https://codereview.chromium.org/2039163002/diff/1/lib/src/relative_span_scanner.dart File lib/src/relative_span_scanner.dart (right): https://codereview.chromium.org/2039163002/diff/1/lib/src/relative_span_scanner.dart#newcode16 lib/src/relative_span_scanner.dart:16: /// inheritance because acanning is often a performance-critical ...
4 years, 6 months ago (2016-06-06 22:56:57 UTC) #3
nweiz
Code review changes
4 years, 6 months ago (2016-06-06 23:22:02 UTC) #4
nweiz
https://codereview.chromium.org/2039163002/diff/1/lib/src/relative_span_scanner.dart File lib/src/relative_span_scanner.dart (right): https://codereview.chromium.org/2039163002/diff/1/lib/src/relative_span_scanner.dart#newcode16 lib/src/relative_span_scanner.dart:16: /// inheritance because acanning is often a performance-critical operation, ...
4 years, 6 months ago (2016-06-06 23:22:22 UTC) #5
nweiz
4 years, 6 months ago (2016-06-06 23:22:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2d44ec8eb90ffa0d7d16048d6ff96702cc27f075 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698