Issue 203673003: Allow [path.fromUri] to take a string as well as a URI.

Issue 203673003: Allow [path.fromUri] to take a string as well as a URI. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow [path.fromUri] to take a string as well as a URI. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=34067

Patch Set 2 : code review #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -62 lines)			Patch
A	pkg/path/CHANGELOG.md	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/path/lib/path.dart	View	1	1 chunk	+9 lines, -5 lines	0 comments	Download
M	pkg/path/lib/src/context.dart	View	1	1 chunk	+12 lines, -5 lines	0 comments	Download
M	pkg/path/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/path/test/posix_test.dart	View	1	1 chunk	+20 lines, -13 lines	0 comments	Download
M	pkg/path/test/url_test.dart	View	1	1 chunk	+22 lines, -14 lines	0 comments	Download
M	pkg/path/test/windows_test.dart	View	1	1 chunk	+29 lines, -21 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/build_environment.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/build.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Couple of nits then LGTM. https://codereview.chromium.org/203673003/diff/1/pkg/path/lib/path.dart File pkg/path/lib/path.dart (right): https://codereview.chromium.org/203673003/diff/1/pkg/path/lib/path.dart#newcode340 pkg/path/lib/path.dart:340: /// // -> 'http://dartlang.org/path/to/foo' ...

6 years, 9 months ago (2014-03-18 20:31:08 UTC) #2

nweiz

Committed patchset #2 manually as r34067 (presubmit successful).

6 years, 9 months ago (2014-03-18 22:02:12 UTC) #3

nweiz

6 years, 9 months ago (2014-03-18 22:02:19 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/203673003/diff/1/pkg/path/lib/path.dart
File pkg/path/lib/path.dart (right):

https://codereview.chromium.org/203673003/diff/1/pkg/path/lib/path.dart#newco...
pkg/path/lib/path.dart:340: ///       // -> 'http://dartlang.org/path/to/foo'
On 2014/03/18 20:31:09, Bob Nystrom wrote:
> We should document and add an example that a relative URI is translated to a
> relative path.

Done.

https://codereview.chromium.org/203673003/diff/1/pkg/path/test/posix_test.dart
File pkg/path/test/posix_test.dart (right):

https://codereview.chromium.org/203673003/diff/1/pkg/path/test/posix_test.dar...
pkg/path/test/posix_test.dart:480:
expect(context.fromUri(Uri.parse('file:///path/to/foo/')), '/path/to/foo/');
On 2014/03/18 20:31:09, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/203673003/diff/1/pkg/path/test/url_test.dart
File pkg/path/test/url_test.dart (right):

https://codereview.chromium.org/203673003/diff/1/pkg/path/test/url_test.dart#...
pkg/path/test/url_test.dart:712:
expect(context.fromUri(Uri.parse('http://dartlang.org/path/to/foo%23bar')),
On 2014/03/18 20:31:09, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/203673003/diff/1/pkg/path/test/windows_test.dart
File pkg/path/test/windows_test.dart (right):

https://codereview.chromium.org/203673003/diff/1/pkg/path/test/windows_test.d...
pkg/path/test/windows_test.dart:604:
expect(context.fromUri(Uri.parse('///C:/path/to/foo')), r'C:\path\to\foo');
On 2014/03/18 20:31:09, Bob Nystrom wrote:
> Long lines.

Done.

Expand Messages | Collapse Messages