Issue 201993002: Fix SecureSocket tests to look up localhost only once, where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201993002: Fix SecureSocket tests to look up localhost only once, where possible. (Closed)

Created:
6 years, 9 months ago by Bill Hesse

Modified:
6 years, 9 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix SecureSocket tests to look up localhost only once, where possible. This is needed because 0.01% of the time, macos will return an IPv6 address for localhost, instead of IPv4, or vice versa. BUG=dartbug.com/12837 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=33750

Patch Set 1 #

Patch Set 2 : Remove useless change to https_client_certificate_test.dart #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+191 lines, -147 lines)			Patch
M	sdk/lib/io/secure_server_socket.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/https_server_test.dart	View	5 chunks	+14 lines, -10 lines	0 comments	Download
M	tests/standalone/io/raw_secure_server_closing_test.dart	View	10 chunks	+18 lines, -11 lines	0 comments	Download
M	tests/standalone/io/raw_secure_server_socket_test.dart	View	10 chunks	+26 lines, -18 lines	0 comments	Download
M	tests/standalone/io/secure_client_raw_server_test.dart	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	tests/standalone/io/secure_client_server_test.dart	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	tests/standalone/io/secure_multiple_client_server_test.dart	View	2 chunks	+19 lines, -19 lines	0 comments	Download
M	tests/standalone/io/secure_server_client_certificate_test.dart	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	tests/standalone/io/secure_server_client_no_certificate_test.dart	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	tests/standalone/io/secure_server_closing_test.dart	View	10 chunks	+18 lines, -11 lines	0 comments	Download
M	tests/standalone/io/secure_server_socket_test.dart	View	9 chunks	+20 lines, -14 lines	0 comments	Download
M	tests/standalone/io/secure_session_resume_test.dart	View	3 chunks	+14 lines, -7 lines	0 comments	Download
M	tests/standalone/io/secure_socket_bad_data_test.dart	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	tests/standalone/io/socket_upgrade_to_secure_test.dart	View	4 chunks	+17 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

6 years, 9 months ago (2014-03-17 16:15:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r33750 (presubmit successful).

Expand Messages | Collapse Messages