Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: tests/standalone/io/secure_server_client_no_certificate_test.dart

Issue 201993002: Fix SecureSocket tests to look up localhost only once, where possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove useless change to https_client_certificate_test.dart Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import "dart:async"; 5 import "dart:async";
6 import "dart:io"; 6 import "dart:io";
7 7
8 import "package:async_helper/async_helper.dart"; 8 import "package:async_helper/async_helper.dart";
9 import "package:expect/expect.dart"; 9 import "package:expect/expect.dart";
10 import "package:path/path.dart";
11 10
12 const HOST_NAME = "localhost"; 11 InternetAddress HOST;
13 const CERTIFICATE = "localhost_cert"; 12 const CERTIFICATE = "localhost_cert";
14 13
15 Future testNoClientCertificate() { 14 Future testNoClientCertificate() {
16 var completer = new Completer(); 15 var completer = new Completer();
17 SecureServerSocket.bind(HOST_NAME, 16 SecureServerSocket.bind(HOST,
18 0, 17 0,
19 CERTIFICATE, 18 CERTIFICATE,
20 requestClientCertificate: true).then((server) { 19 requestClientCertificate: true).then((server) {
21 var clientEndFuture = SecureSocket.connect(HOST_NAME, 20 var clientEndFuture = SecureSocket.connect(HOST,
22 server.port); 21 server.port);
23 server.listen((serverEnd) { 22 server.listen((serverEnd) {
24 X509Certificate certificate = serverEnd.peerCertificate; 23 X509Certificate certificate = serverEnd.peerCertificate;
25 Expect.isNull(certificate); 24 Expect.isNull(certificate);
26 clientEndFuture.then((clientEnd) { 25 clientEndFuture.then((clientEnd) {
27 clientEnd.close(); 26 clientEnd.close();
28 serverEnd.close(); 27 serverEnd.close();
29 server.close(); 28 server.close();
30 completer.complete(); 29 completer.complete();
31 }); 30 });
32 }); 31 });
33 }); 32 });
34 return completer.future; 33 return completer.future;
35 } 34 }
36 35
37 Future testNoRequiredClientCertificate() { 36 Future testNoRequiredClientCertificate() {
38 var completer = new Completer(); 37 var completer = new Completer();
39 bool clientError = false; 38 bool clientError = false;
40 SecureServerSocket.bind(HOST_NAME, 39 SecureServerSocket.bind(HOST,
41 0, 40 0,
42 CERTIFICATE, 41 CERTIFICATE,
43 requireClientCertificate: true).then((server) { 42 requireClientCertificate: true).then((server) {
44 Future clientDone = SecureSocket.connect(HOST_NAME, server.port) 43 Future clientDone = SecureSocket.connect(HOST, server.port)
45 .catchError((e) { clientError = true; }); 44 .catchError((e) { clientError = true; });
46 server.listen((serverEnd) { 45 server.listen((serverEnd) {
47 Expect.fail("Got a unverifiable connection"); 46 Expect.fail("Got a unverifiable connection");
48 }, 47 },
49 onError: (e) { 48 onError: (e) {
50 clientDone.then((_) { 49 clientDone.then((_) {
51 Expect.isTrue(clientError); 50 Expect.isTrue(clientError);
52 server.close(); 51 server.close();
53 completer.complete(); 52 completer.complete();
54 }); 53 });
55 }); 54 });
56 }); 55 });
57 return completer.future; 56 return completer.future;
58 } 57 }
59 58
60 void main() { 59 void main() {
61 String certificateDatabase = Platform.script.resolve('pkcert').toFilePath(); 60 String certificateDatabase = Platform.script.resolve('pkcert').toFilePath();
62 SecureSocket.initialize(database: certificateDatabase, 61 SecureSocket.initialize(database: certificateDatabase,
63 password: 'dartdart', 62 password: 'dartdart',
64 useBuiltinRoots: false); 63 useBuiltinRoots: false);
65 64
66 asyncStart(); 65 asyncStart();
67 testNoRequiredClientCertificate() 66 InternetAddress.lookup("localhost").then((hosts) => HOST = hosts.first)
67 .then((_) => testNoRequiredClientCertificate())
68 .then((_) => testNoClientCertificate()) 68 .then((_) => testNoClientCertificate())
69 .then((_) => asyncEnd()); 69 .then((_) => asyncEnd());
70 } 70 }
OLDNEW
« no previous file with comments | « tests/standalone/io/secure_server_client_certificate_test.dart ('k') | tests/standalone/io/secure_server_closing_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698