Issue 20066004: Change the return value of setField to be in line with non-reflective assignments. Complete unwrapp…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20066004: Change the return value of setField to be in line with non-reflective assignments. Complete unwrapp… (Closed)

Created:
7 years, 5 months ago by rmacnak

Modified:
7 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, ahe, Michael Lippautz (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change the return value of setField to be in line with non-reflective assignments. Complete unwrapping of exceptions for the InstanceMirror invokes. Resolves issue 11219 and issue 11943. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25457

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -56 lines)			Patch
M	runtime/lib/mirrors.cc	View	1	2 chunks	+2 lines, -41 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1	2 chunks	+8 lines, -7 lines	0 comments	Download
M	runtime/tests/vm/dart/isolate_mirror_local_test.dart	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmacnak

https://codereview.chromium.org/20066004/diff/3001/runtime/tests/vm/dart/isolate_mirror_local_test.dart File runtime/tests/vm/dart/isolate_mirror_local_test.dart (left): https://codereview.chromium.org/20066004/diff/3001/runtime/tests/vm/dart/isolate_mirror_local_test.dart#oldcode491 runtime/tests/vm/dart/isolate_mirror_local_test.dart:491: Expect.isTrue(error.stacktrace.toString().contains( We don't have stack traces by default anymore, ...

7 years, 5 months ago (2013-07-24 02:52:45 UTC) #1

rmacnak

7 years, 5 months ago (2013-07-25 00:18:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r25457 (presubmit successful).

Expand Messages | Collapse Messages