Change the return value of setField to be in line with non-reflective assignments. Complete unwrapp…

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
 #include "include/dart_mirrors_api.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"  // TODO(11742): Remove with CreateMirrorRef.
 #include "vm/bootstrap_natives.h"
@@ skipping 991 matching lines @@
 }
 
 
 void HandleMirrorsMessage(Isolate* isolate,
                           Dart_Port reply_port,
                           const Instance& message) {
   UNIMPLEMENTED();
 }
 
 
-// TODO(11742): This is transitional.
-static RawInstance* Reflect(const Instance& reflectee) {
-  Isolate* isolate = Isolate::Current();
-  DARTSCOPE(isolate);
-  return Instance::RawCast(
-      Api::UnwrapHandle(
-          CreateInstanceMirror(
-              Api::NewHandle(isolate, reflectee.raw()))));
-}
-
-
-static void ThrowMirroredUnhandledError(const Error& original_error) {
-  const UnhandledException& unhandled_ex =
-      UnhandledException::Cast(original_error);
-  Instance& exc = Instance::Handle(unhandled_ex.exception());
-  Instance& stack = Instance::Handle(unhandled_ex.stacktrace());
-
-  Object& exc_string_or_error =
-      Object::Handle(DartLibraryCalls::ToString(exc));
-  String& exc_string = String::Handle();
-  // Ignore any errors that might occur in toString.
-  if (exc_string_or_error.IsString()) {
-    exc_string ^= exc_string_or_error.raw();
-  }
-
-  Instance& mirror_on_exc = Instance::Handle(Reflect(exc));
-
-  Array& args = Array::Handle(Array::New(3));
-  args.SetAt(0, mirror_on_exc);
-  args.SetAt(1, exc_string);
-  args.SetAt(2, stack);
-
-  Exceptions::ThrowByType(Exceptions::kMirroredUncaughtExceptionError, args);
-  UNREACHABLE();
-}
-
-
 static void ThrowMirroredCompilationError(const String& message) {
   Array& args = Array::Handle(Array::New(1));
   args.SetAt(0, message);
 
   Exceptions::ThrowByType(Exceptions::kMirroredCompilationError, args);
   UNREACHABLE();
 }
 
 
 static void ThrowInvokeError(const Error& error) {
-  if (error.IsUnhandledException()) {
-    // An ordinary runtime error.
-    ThrowMirroredUnhandledError(error);
-  }
   if (error.IsLanguageError()) {
     // A compilation error that was delayed by lazy compilation.
     const LanguageError& compilation_error = LanguageError::Cast(error);
     String& message = String::Handle(compilation_error.message());
     ThrowMirroredCompilationError(message);
+    UNREACHABLE();
   }
+  Exceptions::PropagateError(error);
   UNREACHABLE();
 }
 
 
 static bool FieldIsUninitialized(const Field& field) {
   ASSERT(!field.IsNull());
 
   // Return getter method for uninitialized fields, rather than the
   // field object, since the value in the field object will not be
   // initialized until the first time the getter is invoked.
@@ skipping 730 matching lines @@
 
 DEFINE_NATIVE_ENTRY(VariableMirror_type, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));
   const Field& field = Field::Handle(ref.GetFieldReferent());
 
   const AbstractType& type = AbstractType::Handle(field.type());
   return CreateTypeMirror(type);
 }
 
 }  // namespace dart