Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 19967002: Remove uses of Path class from tests/standalone. (Closed)

Created:
7 years, 5 months ago by Bill Hesse
Modified:
7 years, 5 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove uses of Path class from tests/standalone. BUG= R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=25399

Patch Set 1 #

Patch Set 2 : Finish remaining files #

Patch Set 3 : CL upload didn't work right #

Patch Set 4 : Fix windows error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -237 lines) Patch
M tests/standalone/coverage_test.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download
M tests/standalone/io/file_read_special_device_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_stat_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 3 chunks +5 lines, -6 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/https_client_certificate_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/https_server_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/link_async_test.dart View 1 2 3 10 chunks +51 lines, -53 lines 0 comments Download
M tests/standalone/io/link_test.dart View 1 2 3 7 chunks +43 lines, -45 lines 0 comments Download
M tests/standalone/io/process_set_exit_code_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/standalone/io/process_shell_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/standalone/io/raw_secure_server_closing_test.dart View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_argument_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_pause_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/regress_7191_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/secure_builtin_roots_database_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_client_raw_server_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_client_server_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_multiple_client_server_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_no_builtin_roots_database_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_server_closing_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_session_resume_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_socket_bad_data_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/stdin_sync_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/test_extension_fail_test.dart View 1 2 chunks +16 lines, -17 lines 0 comments Download
M tests/standalone/io/test_extension_test.dart View 1 1 chunk +16 lines, -17 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/windows_environment_test.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
The only remaining tests using Path are path_test.dart, removed by another CL, and skipping_dart2js_compilations_test.dart, which ...
7 years, 5 months ago (2013-07-23 14:52:02 UTC) #1
Anders Johnsen
LGTM, if you haven't, try running in checked-mode and the analyzer. It might help validating ...
7 years, 5 months ago (2013-07-24 07:38:48 UTC) #2
Bill Hesse
7 years, 5 months ago (2013-07-24 07:45:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r25399 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698