Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: tests/standalone/coverage_test.dart

Issue 19967002: Remove uses of Path class from tests/standalone. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix windows error Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/standalone/io/directory_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/coverage_test.dart
diff --git a/tests/standalone/coverage_test.dart b/tests/standalone/coverage_test.dart
index b48d99be1213e0b1199fd149f84926b23a6cc709..ef5e42d0a8f6f6f17b1ad6cdf68a71d72b28e56e 100644
--- a/tests/standalone/coverage_test.dart
+++ b/tests/standalone/coverage_test.dart
@@ -9,6 +9,7 @@
import "dart:io";
import "dart:async";
+import "package:path/path.dart";
// Coverage tool script relative to the path of this test.
var coverageToolScript = "../../tools/coverage.dart";
@@ -49,16 +50,14 @@ void checkSuccess() {
void main() {
// Compute paths for coverage tool and coverage target relative
// the the path of this script.
- var scriptPath = new Path(Platform.script).directoryPath;
- var toolPath = scriptPath.join(new Path(coverageToolScript)).canonicalize();
- targPath = scriptPath.join(new Path(coverageTargetScript)).canonicalize();
+ var scriptPath = dirname(Platform.script);
+ var toolPath = normalize(join(scriptPath, coverageToolScript));
+ targPath = normalize(join(scriptPath, coverageTargetScript));
- sourceLines = new File(targPath.toNativePath()).readAsLinesSync();
+ sourceLines = new File(targPath).readAsLinesSync();
assert(sourceLines != null);
- var processOpts = [ "--compile_all",
- toolPath.toNativePath(),
- targPath.toNativePath() ];
+ var processOpts = [ "--compile_all", toolPath, targPath ];
Process.start(Platform.executable, processOpts).then((Process process) {
coverageToolProcess = process;
« no previous file with comments | « no previous file | tests/standalone/io/directory_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698