Report an error if a const constructor calls a non-const constructor.

Report an error if a const constructor calls a non-const constructor.

R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25206

[karlklose, 2013-07-19 11:57:32]

LGTM.

[floitsch, 2013-07-19 11:59:45]

DBC.

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
File tests/language/const_constructor_mixin2_test.dart (right):

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
tests/language/const_constructor_mixin2_test.dart:18: var a = const B(42);  ///
01: compile-time error
I would prefer this error on the mixin line:

class B extends A
   with Mixin  /// 01: compile-time-error
   {
  const B(foo) : super(foo);
}

main() {
  var a = const B(42);
  a.nonFinalField = 54;  /// 01: continued
}

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
File tests/language/const_constructor_mixin3_test.dart (right):

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
tests/language/const_constructor_mixin3_test.dart:12: class B extends A with
Mixin {
Ditto: I would prefer the /// 01: compile-time error on the `with Mixin` line.

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
File tests/language/const_constructor_mixin_test.dart (right):

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
tests/language/const_constructor_mixin_test.dart:17: var a = const B(42); ///
01: compile-time error
ditto. I would prefer the "///" on the `with Mixin` line.

[ngeoffray, 2013-07-19 12:04:06]

Thanks Karl and Florian.

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
File tests/language/const_constructor_mixin2_test.dart (right):

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
tests/language/const_constructor_mixin2_test.dart:18: var a = const B(42);  ///
01: compile-time error
On 2013/07/19 11:59:45, floitsch wrote:
> I would prefer this error on the mixin line:
> 
> class B extends A
>    with Mixin  /// 01: compile-time-error
>    {
>   const B(foo) : super(foo);
> }
> 
> main() {
>   var a = const B(42);
>   a.nonFinalField = 54;  /// 01: continued
> }

Done.

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
File tests/language/const_constructor_mixin3_test.dart (right):

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
tests/language/const_constructor_mixin3_test.dart:12: class B extends A with
Mixin {
On 2013/07/19 11:59:45, floitsch wrote:
> Ditto: I would prefer the /// 01: compile-time error on the `with Mixin` line.

Done.

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
File tests/language/const_constructor_mixin_test.dart (right):

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
tests/language/const_constructor_mixin_test.dart:17: var a = const B(42); ///
01: compile-time error
On 2013/07/19 11:59:45, floitsch wrote:
> ditto. I would prefer the "///" on the `with Mixin` line.

Done.

[ngeoffray, 2013-07-19 12:05:43]

Committed patchset #3 manually as r25206 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-07-19 12:19:54]

DBC

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
File tests/language/const_constructor_mixin2_test.dart (right):

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
tests/language/const_constructor_mixin2_test.dart:18: var a = const B(42);  ///
01: compile-time error
Actually, the error is in line 14, because super(foo) is not a const
constructor.

[ngeoffray, 2013-07-19 12:39:40]

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
File tests/language/const_constructor_mixin2_test.dart (right):

https://codereview.chromium.org/19802003/diff/5001/tests/language/const_const...
tests/language/const_constructor_mixin2_test.dart:18: var a = const B(42);  ///
01: compile-time error
On 2013/07/19 12:19:54, Lasse Reichstein Nielsen wrote:
> Actually, the error is in line 14, because super(foo) is not a const
> constructor.

What I like about Florian's suggestion is that the 'none' version of the
multitest runs with a const call.