Report an error if a const constructor calls a non-const constructor.

sdk/lib/_internal/compiler/implementation/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   Element get currentElement;
   Set<Node> get superUses;
 
@@ skipping 1069 matching lines @@
     ClassElement lookupTarget = getSuperOrThisLookupTarget(constructor,
                                                            isSuperCall,
                                                            call);
     Selector constructorSelector =
         visitor.getRedirectingThisOrSuperConstructorSelector(call);
     FunctionElement calledConstructor =
         lookupTarget.lookupConstructor(constructorSelector);
 
     final bool isImplicitSuperCall = false;
     final SourceString className = lookupTarget.name;
-    verifyThatConstructorMatchesCall(calledConstructor,
+    verifyThatConstructorMatchesCall(constructor,
+                                     calledConstructor,
                                      selector,
                                      isImplicitSuperCall,
                                      call,
                                      className,
                                      constructorSelector);
 
     visitor.useElement(call, calledConstructor);
     visitor.world.registerStaticUse(calledConstructor);
     return calledConstructor;
   }
@@ skipping 16 matching lines @@
       ClassElement lookupTarget = getSuperOrThisLookupTarget(constructor,
                                                              isSuperCall,
                                                              functionNode);
       Selector constructorSelector = new Selector.callDefaultConstructor(
           visitor.enclosingElement.getLibrary());
       Element calledConstructor = lookupTarget.lookupConstructor(
           constructorSelector);
 
       final SourceString className = lookupTarget.name;
       final bool isImplicitSuperCall = true;
-      verifyThatConstructorMatchesCall(calledConstructor,
+      verifyThatConstructorMatchesCall(constructor,
+                                       calledConstructor,
                                        callToMatch,
                                        isImplicitSuperCall,
                                        functionNode,
                                        className,
                                        constructorSelector);
 
       visitor.world.registerStaticUse(calledConstructor);
     }
   }
 
   void verifyThatConstructorMatchesCall(
+      FunctionElement caller,
       FunctionElement lookedupConstructor,
       Selector call,
       bool isImplicitSuperCall,
       Node diagnosticNode,
       SourceString className,
       Selector constructorSelector) {
     if (lookedupConstructor == null
         || !lookedupConstructor.isGenerativeConstructor()) {
       var fullConstructorName =
           visitor.compiler.resolver.constructorNameForDiagnostics(
               className,
               constructorSelector.name);
       MessageKind kind = isImplicitSuperCall
           ? MessageKind.CANNOT_RESOLVE_CONSTRUCTOR_FOR_IMPLICIT
           : MessageKind.CANNOT_RESOLVE_CONSTRUCTOR;
       visitor.compiler.reportErrorCode(
           diagnosticNode, kind, {'constructorName': fullConstructorName});
     } else {
       if (!call.applies(lookedupConstructor, visitor.compiler)) {
         MessageKind kind = isImplicitSuperCall
                            ? MessageKind.NO_MATCHING_CONSTRUCTOR_FOR_IMPLICIT
                            : MessageKind.NO_MATCHING_CONSTRUCTOR;
         visitor.compiler.reportErrorCode(diagnosticNode, kind);
+      } else if (caller.modifiers.isConst()
+                 && !lookedupConstructor.modifiers.isConst()) {
+        visitor.compiler.reportErrorCode(
+            diagnosticNode, MessageKind.CONST_CALLS_NON_CONST);
       }
     }
   }
 
   FunctionElement resolveRedirection(FunctionElement constructor,
                                      FunctionExpression functionNode) {
     if (functionNode.initializers == null) return null;
     Link<Node> link = functionNode.initializers.nodes;
     if (!link.isEmpty && Initializers.isConstructorRedirect(link.head)) {
       return resolveSuperOrThisForSend(constructor, functionNode, link.head);
@@ skipping 2898 matching lines @@
     return e;
   }
 
   /// Assumed to be called by [resolveRedirectingFactory].
   Element visitReturn(Return node) {
     Node expression = node.expression;
     return finishConstructorReference(visit(expression),
                                       expression, expression);
   }
 }