Recognize Math's min and max function for doubles and inline the operation.

Recognize Math's min and max function for doubles and inline the operation.

R=regis@google.com, zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25287

[srdjan, 2013-07-19 23:17:51]

Should give 10% speedup on Box2D.

[zra, 2013-07-22 16:21:02]

lgtm

With a couple suggestions for shorter sequences on arm and mips.

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_arm.cc:3390: __ b(&done);
__ vmovd(result, left, double_condition);
__ vmovd(result, right, NegateCondition(double_condition));
__ b(&done);

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_arm.cc:3392: static double kNaN = NAN;
__ LoadDImmediate(result, NAN);

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_mips.cc (right):

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_mips.cc:3122: __ movd(result, right);
It would be okay to add a TODO here for me to add the conditional move
instructions.

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_mips.cc:3130: __ ldc1(result, Address(temp,
0));
__ LoadDImmediate(result, NAN);

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:8914: // ICData of static calls with nume_args_tested() > 0
have initially a
num_args_tested?

[regis, 2013-07-22 16:22:03]

LGTM

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_arm.cc:3389: __ vmovd(result, left);
You could make both vmovd instructions conditional and avoid the conditional
branches.

[srdjan, 2013-07-22 16:42:48]

Thanks. Will submit this, although there is a bug (-0.0 is equal to 0.0
according to IEEE, but not according to min/max). The fix and tests will be part
of a following CL.

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_arm.cc:3389: __ vmovd(result, left);
On 2013/07/22 16:22:03, regis wrote:
> You could make both vmovd instructions conditional and avoid the conditional
> branches.

Done.

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_arm.cc:3390: __ b(&done);
On 2013/07/22 16:21:02, zra wrote:
> __ vmovd(result, left, double_condition);
> __ vmovd(result, right, NegateCondition(double_condition));
> __ b(&done);

Done.

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_arm.cc:3392: static double kNaN = NAN;
On 2013/07/22 16:21:02, zra wrote:
> __ LoadDImmediate(result, NAN);

Done.

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_mips.cc (right):

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_mips.cc:3122: __ movd(result, right);
On 2013/07/22 16:21:02, zra wrote:
> It would be okay to add a TODO here for me to add the conditional move
> instructions.

Done.

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_mips.cc:3130: __ ldc1(result, Address(temp,
0));
On 2013/07/22 16:21:02, zra wrote:
> __ LoadDImmediate(result, NAN);

Done.

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:8914: // ICData of static calls with nume_args_tested() > 0
have initially a
On 2013/07/22 16:21:02, zra wrote:
> num_args_tested?

Done.

[srdjan, 2013-07-22 17:07:56]

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_mips.cc (right):

https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_mips.cc:3130: __ ldc1(result, Address(temp,
0));
On 2013/07/22 16:42:48, srdjan wrote:
> On 2013/07/22 16:21:02, zra wrote:
> > __ LoadDImmediate(result, NAN);
> 
> Done.

Actually, there is no LoadDImmedaite on MIPS yet.

[srdjan, 2013-07-22 17:09:45]

On 2013/07/22 17:07:56, srdjan wrote:
>
https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
> File runtime/vm/intermediate_language_mips.cc (right):
> 
>
https://codereview.chromium.org/19792007/diff/7001/runtime/vm/intermediate_la...
> runtime/vm/intermediate_language_mips.cc:3130: __ ldc1(result, Address(temp,
> 0));
> On 2013/07/22 16:42:48, srdjan wrote:
> > On 2013/07/22 16:21:02, zra wrote:
> > > __ LoadDImmediate(result, NAN);
> > 
> > Done.
> 
> Actually, there is no LoadDImmedaite on MIPS yet.

Using LoadImmediate.

[srdjan, 2013-07-22 17:27:55]

Committed patchset #4 manually as r25287 (presubmit successful).