Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 19792007: Recognize Math's min and max function for doubles and inline the operation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm.cc
===================================================================
--- runtime/vm/intermediate_language_arm.cc (revision 25280)
+++ runtime/vm/intermediate_language_arm.cc (working copy)
@@ -3347,6 +3347,57 @@
}
+LocationSummary* MathMinMaxInstr::MakeLocationSummary() const {
+ if (result_cid() == kDoubleCid) {
+ const intptr_t kNumInputs = 2;
+ const intptr_t kNumTemps = 1;
+ LocationSummary* summary =
+ new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
+ summary->set_in(0, Location::RequiresFpuRegister());
+ summary->set_in(1, Location::RequiresFpuRegister());
+ summary->set_temp(0, Location::RequiresRegister());
+ summary->set_out(Location::RequiresFpuRegister());
+ return summary;
+ }
+ ASSERT(result_cid() == kSmiCid);
+ UNIMPLEMENTED();
+ return NULL;
+}
+
+
+void MathMinMaxInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+ if (result_cid() == kDoubleCid) {
+ Label done, is_nan;
+ DRegister left = EvenDRegisterOf(locs()->in(0).fpu_reg());
+ DRegister right = EvenDRegisterOf(locs()->in(1).fpu_reg());
+ DRegister result = EvenDRegisterOf(locs()->out().fpu_reg());
+ Register temp = locs()->temp(0).reg();
+ __ vcmpd(left, right);
+ __ vmstat();
+ __ b(&is_nan, VS);
+ Condition double_condition, neg_double_condition;
+ if (op_kind() == MethodRecognizer::kMathMin) {
+ double_condition = TokenKindToDoubleCondition(Token::kLT);
+ neg_double_condition = TokenKindToDoubleCondition(Token::kGTE);
+ } else {
+ ASSERT(op_kind() == MethodRecognizer::kMathMax);
+ double_condition = TokenKindToDoubleCondition(Token::kGT);
+ neg_double_condition = TokenKindToDoubleCondition(Token::kLTE);
+ }
+ __ vmovd(result, left, double_condition);
+ __ vmovd(result, right, neg_double_condition);
+ __ b(&done);
+
+ __ Bind(&is_nan);
+ __ LoadDImmediate(result, NAN, temp);
+ __ Bind(&done);
+ return;
+ }
+ ASSERT(result_cid() == kSmiCid);
+ UNIMPLEMENTED();
+}
+
+
LocationSummary* UnarySmiOpInstr::MakeLocationSummary() const {
const intptr_t kNumInputs = 1;
const intptr_t kNumTemps = 0;
@@ -3532,7 +3583,7 @@
void InvokeMathCFunctionInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- // For pow-function return NAN if exponent is NAN.
+ // For pow-function return NaN if exponent is NaN.
Label do_call, skip_call;
if (recognized_kind() == MethodRecognizer::kDoublePow) {
DRegister exp = EvenDRegisterOf(locs()->in(1).fpu_reg());
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698