Issue 197853005: Show object pool on code page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197853005: Show object pool on code page (Closed)

Created:
6 years, 9 months ago by Cutch

Modified:
6 years, 9 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Show object pool on code page BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=33702

Patch Set 2 : #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
M	runtime/bin/vmservice/client/lib/src/elements/code_view.html	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/service/object.dart	View	1	3 chunks	+4 lines, -4 lines	1 comment	Download
M	runtime/bin/vmservice/client/lib/src/service/service.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

https://codereview.chromium.org/197853005/diff/20001/runtime/bin/vmservice/client/lib/src/service/object.dart File runtime/bin/vmservice/client/lib/src/service/object.dart (right): https://codereview.chromium.org/197853005/diff/20001/runtime/bin/vmservice/client/lib/src/service/object.dart#newcode550 runtime/bin/vmservice/client/lib/src/service/object.dart:550: '($exclusiveTicks)'; One line fix for unrelated bug.

6 years, 9 months ago (2014-03-14 14:37:21 UTC) #1

Cutch

6 years, 9 months ago (2014-03-14 17:03:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r33702 (presubmit successful).

Expand Messages | Collapse Messages

Issue 197853005: Show object pool on code page (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages