Changed script to use an explicit package root to execute docgen.

Changed script to use an explicit package root to execute docgen.

BUG=
R=alanknight@google.com, efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25286

[janicejl, 2013-07-19 01:21:48]

Since tuesday it is not possible to run docgen unless using an explicit package
root. Have updated the upload_docgen script to use an explicit package root so
we can conveniently upload new docs.

[Emily Fortuna, 2013-07-19 15:56:44]

https://codereview.chromium.org/19775011/diff/1/pkg/docgen/bin/upload_docgen.py
File pkg/docgen/bin/upload_docgen.py (right):

https://codereview.chromium.org/19775011/diff/1/pkg/docgen/bin/upload_docgen....
pkg/docgen/bin/upload_docgen.py:24: PACKAGE_ROOT =
abspath(join(dirname(__file__), '../../../%s/%s/packages/'
in addition to this constant, can you also allow a user to specify the package
root via command line argument?

[Alan Knight, 2013-07-19 16:29:48]

lgtm

[janicejl, 2013-07-19 22:31:31]

https://codereview.chromium.org/19775011/diff/1/pkg/docgen/bin/upload_docgen.py
File pkg/docgen/bin/upload_docgen.py (right):

https://codereview.chromium.org/19775011/diff/1/pkg/docgen/bin/upload_docgen....
pkg/docgen/bin/upload_docgen.py:24: PACKAGE_ROOT =
abspath(join(dirname(__file__), '../../../%s/%s/packages/'
On 2013/07/19 15:56:44, Emily Fortuna wrote:
> in addition to this constant, can you also allow a user to specify the package
> root via command line argument?

Done.

[Emily Fortuna, 2013-07-19 22:49:27]

https://codereview.chromium.org/19775011/diff/6001/pkg/docgen/bin/upload_docg...
File pkg/docgen/bin/upload_docgen.py (right):

https://codereview.chromium.org/19775011/diff/6001/pkg/docgen/bin/upload_docg...
pkg/docgen/bin/upload_docgen.py:11: import argparse
Our buildbots actually still have python 2.6, and argparse was introduced in
python 2.7. You can use optparse instead. It's nearly identical from your
perspective.

https://codereview.chromium.org/19775011/diff/6001/pkg/docgen/bin/upload_docg...
pkg/docgen/bin/upload_docgen.py:36: parser.add_argument('--package-root',
action=SetPackageRoot,
Instead of having the separate SetPackageRoot class and everything you can just
use action='store':

parser.add_option('--package-root', dest='pkg_root',
      help = 'The package root for dart (default is in the build directory).',
      action = 'store', default = PACKAGE_ROOT)
PACKAGE_ROOT = parser.parse_args().pkg_root
etc

[janicejl, 2013-07-22 16:56:11]

https://codereview.chromium.org/19775011/diff/6001/pkg/docgen/bin/upload_docg...
File pkg/docgen/bin/upload_docgen.py (right):

https://codereview.chromium.org/19775011/diff/6001/pkg/docgen/bin/upload_docg...
pkg/docgen/bin/upload_docgen.py:11: import argparse
On 2013/07/19 22:49:28, Emily Fortuna wrote:
> Our buildbots actually still have python 2.6, and argparse was introduced in
> python 2.7. You can use optparse instead. It's nearly identical from your
> perspective.

Done.

https://codereview.chromium.org/19775011/diff/6001/pkg/docgen/bin/upload_docg...
pkg/docgen/bin/upload_docgen.py:36: parser.add_argument('--package-root',
action=SetPackageRoot,
On 2013/07/19 22:49:28, Emily Fortuna wrote:
> Instead of having the separate SetPackageRoot class and everything you can
just
> use action='store':
> 
> parser.add_option('--package-root', dest='pkg_root',
>       help = 'The package root for dart (default is in the build directory).',
>       action = 'store', default = PACKAGE_ROOT)
> PACKAGE_ROOT = parser.parse_args().pkg_root
> etc

Done.

[Emily Fortuna, 2013-07-22 17:05:03]

lgtm

[janicejl, 2013-07-22 17:22:49]

Committed patchset #3 manually as r25286 (presubmit successful).