Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: pkg/docgen/bin/upload_docgen.py

Issue 19775011: Changed script to use an explicit package root to execute docgen. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/docgen/bin/upload_docgen.py
diff --git a/pkg/docgen/bin/upload_docgen.py b/pkg/docgen/bin/upload_docgen.py
index b7cdb924741401ae2830917cb908a1ba47351757..22903e1beb245fd1b60622571781f32be0d6104a 100644
--- a/pkg/docgen/bin/upload_docgen.py
+++ b/pkg/docgen/bin/upload_docgen.py
@@ -8,6 +8,7 @@
Google Cloud Storage for the documentation viewer.
"""
+import optparse
import os
from os.path import join, dirname, abspath, exists
import platform
@@ -21,8 +22,28 @@ from upload_sdk import ExecuteCommand
DART = abspath(join(dirname(__file__), '../../../%s/%s/dart-sdk/bin/dart'
% (utils.BUILD_ROOT[utils.GuessOS()], utils.GetBuildConf('release',
utils.GuessArchitecture()))))
+PACKAGE_ROOT = abspath(join(dirname(__file__), '../../../%s/%s/packages/'
+ % (utils.BUILD_ROOT[utils.GuessOS()], utils.GetBuildConf('release',
+ utils.GuessArchitecture()))))
GSUTIL = utils.GetBuildbotGSUtilPath()
GS_SITE = 'gs://dartlang-docgen'
+DESCRIPTION='Runs docgen.dart on the SDK libraries, and uploads them to Google \
+ Cloud Storage for the dartdoc-viewer. '
+
+
+def GetOptions():
+ parser = optparse.OptionParser(description=DESCRIPTION)
+ parser.add_option('--package-root', dest='pkg_root',
+ help='The package root for dart. (Default is in the build directory.)',
+ action='store', default=PACKAGE_ROOT)
+ (options, args) = parser.parse_args()
+ SetPackageRoot(options.pkg_root)
+
+
+def SetPackageRoot(path):
+ global PACKAGE_ROOT
+ if exists(path):
+ PACKAGE_ROOT = abspath(path)
def SetGsutil():
@@ -41,10 +62,13 @@ def Upload(source, target):
def main():
+ GetOptions()
+
SetGsutil()
# Execute Docgen.dart on the SDK.
- ExecuteCommand([DART, abspath(join(dirname(__file__), 'docgen.dart')),
+ ExecuteCommand([DART, '--checked', '--package-root=' + PACKAGE_ROOT,
+ abspath(join(dirname(__file__), 'docgen.dart')),
'--parse-sdk'])
# Use SVN Revision to get the revision number.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698