Use library prefixes in scope of the mixin class when compiling a functions of

Use library prefixes in scope of the mixin class when compiling a functions of
a mixin application (issue 11891).

Committed: https://code.google.com/p/dart/source/detail?r=25233

[hausner, 2013-07-19 05:21:58]

DBC: I wonder why we look up the library prefix through the class and not
through the library  scope. Maybe you can add a todo to check this out. I also
wonder why we did the right thing in initializer expressions before this fix.

[regis, 2013-07-19 18:08:00]

On 2013/07/19 05:21:58, hausner wrote:
> DBC: I wonder why we look up the library prefix through the class and not
> through the library  scope. Maybe you can add a todo to check this out. I also
> wonder why we did the right thing in initializer expressions before this fix.

These are good questions that you should be able to answer better than me, so I
added a TODO(hausner) :-)
Ivan said LGTM, so I'll submit to fix the bug and we can revisit to clean this
up.

Thanks,
Regis

[regis, 2013-07-19 18:08:22]

Committed patchset #2 manually as r25233 (presubmit successful).

[Ivan Posva, 2013-07-19 19:00:25]

LGTMwC -ip

https://codereview.chromium.org/19763007/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/19763007/diff/1/runtime/vm/parser.cc#newcode2801
runtime/vm/parser.cc:2801: if (current_class().mixin() == Type::null()) {
Please add a TODO to figure out why we are not using the librar() to lookup here
and other places below.

[regis, 2013-07-19 20:48:52]

On 2013/07/19 19:00:25, Ivan Posva wrote:
> LGTMwC -ip
> 
> https://codereview.chromium.org/19763007/diff/1/runtime/vm/parser.cc
> File runtime/vm/parser.cc (right):
> 
>
https://codereview.chromium.org/19763007/diff/1/runtime/vm/parser.cc#newcode2801
> runtime/vm/parser.cc:2801: if (current_class().mixin() == Type::null()) {
> Please add a TODO to figure out why we are not using the librar() to lookup
here
> and other places below.

Thanks. It was submitted with a TODO.