runtime/vm/parser.cc - Issue 19763007: Use library prefixes in scope of the mixin class when compiling a functions of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 19763007: Use library prefixes in scope of the mixin class when compiling a functions of (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

===================================================================

--- runtime/vm/parser.cc (revision 25231)

+++ runtime/vm/parser.cc (working copy)

@@ -2798,7 +2798,14 @@

*(qual_ident->ident),

NULL)) {

LibraryPrefix& lib_prefix = LibraryPrefix::ZoneHandle();

- lib_prefix = current_class().LookupLibraryPrefix(*(qual_ident->ident));

+ if (current_class().mixin() == Type::null()) {

+ lib_prefix = current_class().LookupLibraryPrefix(*(qual_ident->ident));

+ } else {

+ // TODO(hausner): Should we resolve the prefix via the library scope

+ // rather than via the class?

+ Class& cls = Class::Handle(parsed_function()->function().origin());

+ lib_prefix = cls.LookupLibraryPrefix(*(qual_ident->ident));

+ }

if (!lib_prefix.IsNull()) {

// We have a library prefix qualified identifier, unless the prefix is

// shadowed by a type parameter in scope.

« no previous file with comments | « no previous file | tests/language/mixin_prefix_lib.dart » ('j') | no next file with comments »