Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 197313010: Initial refactorings to support archiving the src and debian package builds. (Closed)

Created:
6 years, 9 months ago by ricow1
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Initial refactorings to support archiving the src and debian package builds. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33747

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -24 lines) Patch
M tools/bots/bot.py View 1 chunk +6 lines, -3 lines 0 comments Download
M tools/bots/bot_utils.py View 2 chunks +9 lines, -0 lines 0 comments Download
M tools/bots/src-tarball.py View 2 chunks +21 lines, -2 lines 0 comments Download
M tools/create_debian_packages.py View 1 2 3 4 chunks +26 lines, -9 lines 0 comments Download
M tools/create_tarball.py View 1 2 3 4 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
6 years, 9 months ago (2014-03-14 14:16:42 UTC) #1
Søren Gjesse
lgtm
6 years, 9 months ago (2014-03-17 08:02:32 UTC) #2
ricow1
PTAL Added checking of the passed in options, default value the output dir, but require ...
6 years, 9 months ago (2014-03-17 13:16:26 UTC) #3
Søren Gjesse
lgtm
6 years, 9 months ago (2014-03-17 14:08:16 UTC) #4
ricow1
6 years, 9 months ago (2014-03-17 14:11:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r33747 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698