Initial refactorings to support archiving the src and debian package builds.

tools/create_tarball.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 
 # Script to build a tarball of the Dart source.
 #
 # The tarball includes all the source needed to build Dart. This
@@ skipping 14 matching lines @@
 import optparse
 import sys
 import tarfile
 import utils
 
 from os import listdir, makedirs
 from os.path import join, exists, split, dirname, abspath
 
 HOST_OS = utils.GuessOS()
 DART_DIR = abspath(join(__file__, '..', '..'))
-
 # Flags.
 verbose = False
 
 # Name of the dart directory when unpacking the tarball.
 versiondir = ''
 
 # Ignore Git/SVN files, checked-in binaries, backup files, etc..
 ignoredPaths = ['tools/testing/bin',
                 'third_party/7zip', 'third_party/android_tools',
                 'third_party/clang', 'third_party/d8',
                 'third_party/firefox_jsshell']
 ignoredDirs = ['.svn', '.git']
 ignoredEndings = ['.mk', '.pyc', 'Makefile', '~']
 
 def BuildOptions():
   result = optparse.OptionParser()
   result.add_option("-v", "--verbose",
       help='Verbose output.',
       default=False, action="store_true")
+  result.add_option("--tar_filename",
+                    default=None,
+                    help="The output file.")
+
   return result
 
 def Filter(tar_info):
   # Get the name of the file relative to the dart directory. Note the
   # name from the TarInfo does not include a leading slash.
   assert tar_info.name.startswith(DART_DIR[1:])
   original_name = tar_info.name[len(DART_DIR):]
   _, tail = split(original_name)
   if tail in ignoredDirs:
     return None
@@ skipping 31 matching lines @@
     f.write('  * Generated file.\n')
     f.write('\n')
     f.write(' -- Dart Team <misc@dartlang.org>  %s\n' %
             datetime.datetime.utcnow().strftime('%a, %d %b %Y %X +0000'))
 
 def GenerateSvnRevision(filename, svn_revision):
   with open(filename, 'w') as f:
     f.write(svn_revision)
 
 
-def CreateTarball():
+def CreateTarball(tarfilename):
   global ignoredPaths  # Used for adding the output directory.
   # Generate the name of the tarfile
   version = utils.GetVersion()
   global versiondir
   versiondir = 'dart-%s' % version
-  tarname = '%s.tar.gz' % versiondir
   debian_dir = 'tools/linux_dist_support/debian'
-  # Create the tar file in the build directory.
-  builddir = utils.GetBuildDir(HOST_OS, HOST_OS)
-  tardir = join(DART_DIR, builddir)
   # Don't include the build directory in the tarball (ignored paths
   # are relative to DART_DIR).
+  builddir = utils.GetBuildDir(HOST_OS, HOST_OS)
   ignoredPaths.append(builddir)
-  if not exists(tardir):
-    makedirs(tardir)
-  tarfilename = join(tardir, tarname)
+
   print 'Creating tarball: %s' % tarfilename
   with tarfile.open(tarfilename, mode='w:gz') as tar:
     for f in listdir(DART_DIR):
       tar.add(join(DART_DIR, f), filter=Filter)
     for f in listdir(join(DART_DIR, debian_dir)):
       tar.add(join(DART_DIR, debian_dir, f),
               arcname='%s/debian/%s' % (versiondir, f))
 
     with utils.TempDir() as temp_dir:
       # Generate and add debian/copyright
@@ skipping 17 matching lines @@
     print 'Tarball can only be created on linux'
     return -1
 
   # Parse the options.
   parser = BuildOptions()
   (options, args) = parser.parse_args()
   if options.verbose:
     global verbose
     verbose = True
 
-  CreateTarball()
+  if not options.tar_filename:
+    raise Exception('Please specify an output filename')
+
+  CreateTarball(options.tar_filename)
 
 if __name__ == '__main__':
   sys.exit(Main())