Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 196953007: Fix LibraryMirror.invoke to call through the contents of an implicit getter. (Closed)

Created:
6 years, 9 months ago by rmacnak
Modified:
6 years, 9 months ago
Reviewers:
floitsch, gbracha, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch
Visibility:
Public.

Description

Fix LibraryMirror.invoke to call through the contents of an implicit getter. BUG=http://dartbug.com/17452 R=asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=33682

Patch Set 1 #

Total comments: 2

Patch Set 2 : split multitest for easier marking of dart2js partial failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -76 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +20 lines, -30 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/invoke_call_through_getter_previously_accessed_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_getter_test.dart View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + tests/lib/mirrors/invoke_call_through_implicit_getter_previously_accessed_test.dart View 1 4 chunks +26 lines, -20 lines 0 comments Download
A + tests/lib/mirrors/invoke_call_through_implicit_getter_test.dart View 1 5 chunks +30 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
6 years, 9 months ago (2014-03-12 23:40:15 UTC) #1
floitsch
I would prefer to split the multitest. I know, it duplicates code, but dart2js only ...
6 years, 9 months ago (2014-03-13 12:06:42 UTC) #2
siva
The VM changes LGTM.
6 years, 9 months ago (2014-03-13 17:32:05 UTC) #3
rmacnak
On 2014/03/13 12:06:42, floitsch wrote: > I would prefer to split the multitest. > I ...
6 years, 9 months ago (2014-03-13 17:41:36 UTC) #4
gbracha
tests lgtm
6 years, 9 months ago (2014-03-14 01:03:44 UTC) #5
rmacnak
6 years, 9 months ago (2014-03-14 01:14:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r33682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698