Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: tests/lib/mirrors/invoke_call_through_implicit_getter_test.dart

Issue 196953007: Fix LibraryMirror.invoke to call through the contents of an implicit getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: split multitest for easier marking of dart2js partial failures Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/invoke_call_through_implicit_getter_previously_accessed_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/invoke_call_through_implicit_getter_test.dart
diff --git a/tests/lib/mirrors/invoke_call_through_getter_test.dart b/tests/lib/mirrors/invoke_call_through_implicit_getter_test.dart
similarity index 74%
copy from tests/lib/mirrors/invoke_call_through_getter_test.dart
copy to tests/lib/mirrors/invoke_call_through_implicit_getter_test.dart
index 71dca685971d1aa2a189395bb5eb7b34ac2ebb51..6aa5cdf5aee2be0a0fc593693e6627598b633859 100644
--- a/tests/lib/mirrors/invoke_call_through_getter_test.dart
+++ b/tests/lib/mirrors/invoke_call_through_implicit_getter_test.dart
@@ -1,8 +1,8 @@
-// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library test.invoke_call_through_getter;
+library test.invoke_call_through_implicit_getter;
import 'dart:mirrors';
@@ -16,14 +16,20 @@ class FakeFunctionNSM {
}
class C {
- get fakeFunctionCall => new FakeFunctionCall();
- get fakeFunctionNSM => new FakeFunctionNSM();
- get closure => (x, y) => '2 $this $x $y';
- get closureOpt => (x, y, [z, w]) => '3 $this $x $y $z $w';
- get closureNamed => (x, y, {z, w}) => '4 $this $x $y $z $w';
- get notAClosure => 'Not a closure';
+ var fakeFunctionCall = new FakeFunctionCall();
+ var fakeFunctionNSM = new FakeFunctionNSM();
+ var closure; // = (x, y) => '2 $this $x $y';
+ var closureOpt; // = (x, y, [z, w]) => '3 $this $x $y $z $w';
+ var closureNamed; // = (x, y, {z, w}) => '4 $this $x $y $z $w';
+ var notAClosure = 'Not a closure';
noSuchMethod(msg) => 'DNU';
+ C() {
+ closure = (x, y) => '2 $this $x $y';
+ closureOpt = (x, y, [z, w]) => '3 $this $x $y $z $w';
+ closureNamed = (x, y, {z, w}) => '4 $this $x $y $z $w';
+ }
+
toString() => 'C';
}
@@ -62,12 +68,12 @@ testInstanceReflective() {
}
class D {
- static get fakeFunctionCall => new FakeFunctionCall();
- static get fakeFunctionNSM => new FakeFunctionNSM();
- static get closure => (x, y) => '2 $x $y';
- static get closureOpt => (x, y, [z, w]) => '3 $x $y $z $w';
- static get closureNamed => (x, y, {z, w}) => '4 $x $y $z $w';
- static get notAClosure => 'Not a closure';
+ static var fakeFunctionCall = new FakeFunctionCall();
+ static var fakeFunctionNSM = new FakeFunctionNSM();
+ static var closure = (x, y) => '2 $x $y';
+ static var closureOpt = (x, y, [z, w]) => '3 $x $y $z $w';
+ static var closureNamed = (x, y, {z, w}) => '4 $x $y $z $w';
+ static var notAClosure = 'Not a closure';
}
testClassBase() {
@@ -96,12 +102,12 @@ testClassReflective() {
(e) => e is NoSuchMethodError);
}
-get fakeFunctionCall => new FakeFunctionCall();
-get fakeFunctionNSM => new FakeFunctionNSM();
-get closure => (x, y) => '2 $x $y';
-get closureOpt => (x, y, [z, w]) => '3 $x $y $z $w';
-get closureNamed => (x, y, {z, w}) => '4 $x $y $z $w';
-get notAClosure => 'Not a closure';
+var fakeFunctionCall = new FakeFunctionCall();
+var fakeFunctionNSM = new FakeFunctionNSM();
+var closure = (x, y) => '2 $x $y';
+var closureOpt = (x, y, [z, w]) => '3 $x $y $z $w';
+var closureNamed = (x, y, {z, w}) => '4 $x $y $z $w';
+var notAClosure = 'Not a closure';
testLibraryBase() {
Expect.equals('1 5 6', fakeFunctionCall(5, 6));
@@ -130,10 +136,11 @@ testLibraryReflective() {
}
main() {
- testInstanceBase();
+ // Do not access the getters/closures at the base level in this variant.
+ //testInstanceBase();
testInstanceReflective();
- testClassBase();
+ //testClassBase();
testClassReflective();
- testLibraryBase();
+ //testLibraryBase();
testLibraryReflective();
}
« no previous file with comments | « tests/lib/mirrors/invoke_call_through_implicit_getter_previously_accessed_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698