Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 19678020: Implements ARM SIMD comparison instructions. (Closed)

Created:
7 years, 5 months ago by zra
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, Cutch
Visibility:
Public.

Description

Implements ARM SIMD comparison instructions. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25189

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+598 lines, -3 lines) Patch
M runtime/vm/assembler_arm.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 chunks +50 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 2 chunks +370 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 3 chunks +141 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
7 years, 5 months ago (2013-07-18 22:17:03 UTC) #1
regis
LGTM You are on a roll!
7 years, 5 months ago (2013-07-18 22:29:54 UTC) #2
zra
On 2013/07/18 22:29:54, regis wrote: > LGTM > > You are on a roll! Thanks! ...
7 years, 5 months ago (2013-07-18 22:49:11 UTC) #3
zra
7 years, 5 months ago (2013-07-18 22:56:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698