Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1648)

Issue 196603009: Correct capacity reporting for new space; show external size in Observatory. (Closed)

Created:
6 years, 9 months ago by koda
Modified:
6 years, 9 months ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Correct capacity reporting for new space; show external size in Observatory. Before, the reported capacity included *both* semi-spaces, which seems wrong. Also exclude external size from capacity, to be consistent with old space and the comment on Heap::CapacityInWords. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33625

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/scavenger.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 9 months ago (2014-03-12 22:17:54 UTC) #1
Cutch
lgtm remember to follow the directions in HACKING.txt before doing the final commit.
6 years, 9 months ago (2014-03-12 22:39:58 UTC) #2
koda
6 years, 9 months ago (2014-03-12 23:12:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r33625 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698