runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart - Issue 196603009: Correct capacity reporting for new space; show external size in Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart

Issue 196603009: Correct capacity reporting for new space; show external size in Observatory. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart

===================================================================

--- runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart (revision 33596)

+++ runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart (working copy)

@@ -133,10 +133,12 @@

var heap = profile['heaps']['new'];

_newPieDataTable.addRow(['Used', heap['used']]);

_newPieDataTable.addRow(['Free', heap['capacity'] - heap['used']]);

+ _newPieDataTable.addRow(['External', heap['external']]);

_oldPieDataTable.clearRows();

heap = profile['heaps']['old'];

_oldPieDataTable.addRow(['Used', heap['used']]);

_oldPieDataTable.addRow(['Free', heap['capacity'] - heap['used']]);

+ _oldPieDataTable.addRow(['External', heap['external']]);

_draw();

}

« no previous file with comments | « runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js ('k') | runtime/vm/scavenger.h » ('j') | no next file with comments »