Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 196473008: Mark addEventListeners as Unsupported when called for cross-frame window actions. (Closed)

Created:
6 years, 9 months ago by Emily Fortuna
Modified:
6 years, 9 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Mark addEventListeners as Unsupported when called for cross-frame window actions. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=33615

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -8 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/dom/src/dart2js_DOMImplementation.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Fix for: https://code.google.com/p/dart/issues/detail?id=16937
6 years, 9 months ago (2014-03-12 21:17:29 UTC) #1
vsm
lgtm
6 years, 9 months ago (2014-03-12 21:22:16 UTC) #2
Emily Fortuna
6 years, 9 months ago (2014-03-12 21:24:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33615 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698