Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 196473008: Mark addEventListeners as Unsupported when called for cross-frame window actions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 15967d9542aafdadef752de74c18407fda2f3671..82454e38792a675bb78e6030adc5a871deec3470 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -35411,15 +35411,19 @@ class _DOMWindowCrossFrame implements WindowBase {
}
// TODO(efortuna): Remove this method. dartbug.com/16814
- Events get on => throw new UnimplementedError();
+ Events get on => throw new UnsupportedError(
+ 'You can only attach EventListeners to your own window.');
// TODO(efortuna): Remove this method. dartbug.com/16814
void addEventListener(String type, EventListener listener, [bool useCapture])
- => throw new UnimplementedError();
+ => throw new UnsupportedError(
+ 'You can only attach EventListeners to your own window.');
// TODO(efortuna): Remove this method. dartbug.com/16814
- bool dispatchEvent(Event event) => throw new UnimplementedError();
+ bool dispatchEvent(Event event) => throw new UnsupportedError(
+ 'You can only attach EventListeners to your own window.');
// TODO(efortuna): Remove this method. dartbug.com/16814
void removeEventListener(String type, EventListener listener,
- [bool useCapture]) => throw new UnimplementedError();
+ [bool useCapture]) => throw new UnsupportedError(
+ 'You can only attach EventListeners to your own window.');
}
class _LocationCrossFrame implements LocationBase {
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698