Issue 196413011: - Implement a PauseTimerScope so that we can properly exclude

Issue 196413011: - Implement a PauseTimerScope so that we can properly exclude (Closed)

Created:
6 years, 9 months ago by Ivan Posva

Modified:
6 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Implement a PauseTimerScope so that we can properly exclude times when a TimerScope is active. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33662

Patch Set 3 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -68 lines)			Patch
M	runtime/vm/allocation.h	View	1 2	1 chunk	+2 lines, -7 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2	10 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2	5 chunks	+40 lines, -31 lines	0 comments	Download
M	runtime/vm/timer.h	View	1 2	2 chunks	+50 lines, -14 lines	0 comments	Download
M	runtime/vm/timer.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/196413011/diff/20001/runtime/vm/timer.h File runtime/vm/timer.h (right): https://codereview.chromium.org/196413011/diff/20001/runtime/vm/timer.h#newcode151 runtime/vm/timer.h:151: : StackResource(isolate), flag_(flag), nested_(false), timer_(timer) { indent https://codereview.chromium.org/196413011/diff/20001/runtime/vm/timer.h#newcode169 ...

6 years, 9 months ago (2014-03-13 20:03:09 UTC) #2

Ivan Posva

Thanks, -Ivan https://codereview.chromium.org/196413011/diff/20001/runtime/vm/timer.h File runtime/vm/timer.h (right): https://codereview.chromium.org/196413011/diff/20001/runtime/vm/timer.h#newcode151 runtime/vm/timer.h:151: : StackResource(isolate), flag_(flag), nested_(false), timer_(timer) { On ...

6 years, 9 months ago (2014-03-13 20:36:18 UTC) #3

Ivan Posva

6 years, 9 months ago (2014-03-13 20:38:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r33662 (presubmit successful).

Expand Messages | Collapse Messages