- Implement a PauseTimerScope so that we can properly exclude

runtime/vm/timer.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_TIMER_H_
 #define VM_TIMER_H_
 
 #include "vm/allocation.h"
 #include "vm/flags.h"
 #include "vm/os.h"
@@ skipping 91 matching lines @@
   void PrintTimersToJSONProperty(JSONObject* jsobj);
 
  private:
 #define TIMER_FIELD(name, msg) Timer name##_;
   TIMER_LIST(TIMER_FIELD)
 #undef TIMER_FIELD
   bool padding_;
   DISALLOW_COPY_AND_ASSIGN(TimerList);
 };
 
-// Timer Usage.
-#define START_TIMER(name)                                                      \
-  Isolate::Current()->timer_list().name().Start();
-
-#define STOP_TIMER(name)                                                       \
-  Isolate::Current()->timer_list().name().Stop();
-
 // The class TimerScope is used to start and stop a timer within a scope.
 // It is used as follows:
 // {
-//   TIMERSCOPE(name_of_timer);
-//   ....
+//   TimerScope timer(FLAG_name_of_flag, timer, isolate);
 //   .....
 //   code that needs to be timed.
 //   ....
 // }
 class TimerScope : public StackResource {
  public:
   TimerScope(bool flag, Timer* timer, BaseIsolate* isolate = NULL)
       : StackResource(isolate), flag_(flag), nested_(false), timer_(timer) {
     if (flag_) {
       if (!timer_->running()) {
@@ skipping 11 matching lines @@
     }
   }
 
  private:
   bool flag_;
   bool nested_;
   Timer* timer_;
   DISALLOW_COPY_AND_ASSIGN(TimerScope);
 };
 
-#define TIMERSCOPE(name)                                                       \
-  TimerScope vm_internal_timer_(true,                                          \
-                                &(Isolate::Current()->timer_list().name()))
+
+class PauseTimerScope : public StackResource {
+ public:
+  PauseTimerScope(bool flag, Timer* timer, BaseIsolate* isolate = NULL)
+  : StackResource(isolate), flag_(flag), nested_(false), timer_(timer) {

[srdjan, 2014/03/13 20:03:09]

indent

[Ivan Posva, 2014/03/13 20:36:18]

Done.

+    if (flag_) {
+      if (timer_->running()) {
+        timer_->Stop();
+      } else {
+        nested_ = true;
+      }
+    }
+  }
+  ~PauseTimerScope() {
+    if (flag_) {
+      if (!nested_) {
+        timer_->Start();
+      }
+    }
+  }
+
+ private:
+  bool flag_;

[srdjan, 2014/03/13 20:03:09]

const

[Ivan Posva, 2014/03/13 20:36:18]

Done.

+  bool nested_;
+  Timer* timer_;
+  DISALLOW_COPY_AND_ASSIGN(PauseTimerScope);
+};
+
+
+// Macros to deal with named timers in the isolate.
+#define START_TIMER(isolate, name)                                             \
+isolate->timer_list().name().Start();
+
+#define STOP_TIMER(isolate, name)                                              \
+isolate->timer_list().name().Stop();
+
+#define TIMERSCOPE(isolate, name)                                              \
+  TimerScope vm_internal_timer_(true, &(isolate->timer_list().name()), isolate)
+
+#define PAUSETIMERSCOPE(isolate, name)                                         \
+PauseTimerScope vm_internal_timer_(true,                                       \
+                                   &(isolate->timer_list().name()),            \
+                                   isolate)
 
 }  // namespace dart
 
 #endif  // VM_TIMER_H_