Change in the Dart command line analyzer, Logger.logError takes a String, not Error types. This wi…

Nit change in the Dart command line analyzer and analysis server.

Logger.logError takes a String, not Error types.  This will enable the exception to be printed, instead of the message '<SomeError> is not a String'.

Also, in the command line version of the dart analyzer, I put in a commented out stdout/stderr logger for developers.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33587

[jwren, 2014-03-11 23:53:36]

https://codereview.chromium.org/196373003/diff/1/pkg/analyzer/lib/src/analyze...
File pkg/analyzer/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/196373003/diff/1/pkg/analyzer/lib/src/analyze...
pkg/analyzer/lib/src/analyzer_impl.dart:162: //   
AnalysisEngine.instance.logger = new StdLogger();
Do we want an additional --verbose flag to enable this for everyone?

[scheglov, 2014-03-12 00:19:36]

Do we want also to log a stack trace?

[Brian Wilkerson, 2014-03-12 13:19:17]

LGTM

https://codereview.chromium.org/196373003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/196373003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:140:
AnalysisEngine.instance.logger.logError(exception.toString());
We definitely want to log the stack trace.

https://codereview.chromium.org/196373003/diff/1/pkg/analyzer/lib/src/analyze...
File pkg/analyzer/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/196373003/diff/1/pkg/analyzer/lib/src/analyze...
pkg/analyzer/lib/src/analyzer_impl.dart:162: //   
AnalysisEngine.instance.logger = new StdLogger();
> Do we want an additional --verbose flag to enable this for everyone?

I would probably call it "--debug", but it seems like a good idea. I probably
wouldn't document it though.

[jwren, 2014-03-12 16:28:44]

https://codereview.chromium.org/196373003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/196373003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:140:
AnalysisEngine.instance.logger.logError(exception.toString());
Done.

https://codereview.chromium.org/196373003/diff/1/pkg/analyzer/lib/src/analyze...
File pkg/analyzer/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/196373003/diff/1/pkg/analyzer/lib/src/analyze...
pkg/analyzer/lib/src/analyzer_impl.dart:162: //   
AnalysisEngine.instance.logger = new StdLogger();
Will add the flag in a follow up CL.

[jwren, 2014-03-12 16:30:28]

Committed patchset #1 manually as r33587 (presubmit successful).