Change in the Dart command line analyzer, Logger.logError takes a String, not Error types. This wi…

pkg/analyzer/lib/src/analyzer_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_impl;
 
 import 'dart:async';
 
 import 'dart:io';
 
@@ skipping 107 matching lines @@
         stdout.writeln("resolve:$resolveTime");
         stdout.writeln("errors:$errorsTime");
         stdout.writeln("hints:$hintsTime");
         stdout.writeln("angular:$angularTime");
         stdout.writeln("other:${totalTime
              - (ioTime + scanTime + parseTime + resolveTime + errorsTime + hintsTime
              + angularTime)}");
         stdout.writeln("total:$totalTime");
       }
     }).catchError((exception, stackTrace) {
-      AnalysisEngine.instance.logger.logError(exception);
+      AnalysisEngine.instance.logger.logError(exception.toString());
     });
   }
 
   /// Returns the maximal [ErrorSeverity] of the recorded errors.
   ErrorSeverity get maxErrorSeverity {
     var status = ErrorSeverity.NONE;
     for (AnalysisErrorInfo errorInfo in errorInfos) {
       for (AnalysisError error in errorInfo.errors) {
         var severity = error.errorCode.errorSeverity;
         status = status.max(severity);
@@ skipping 12 matching lines @@
       } else {
         packageDirectory = getPackageDirectoryFor(sourceFile);
       }
       if (packageDirectory != null) {
         resolvers.add(new PackageUriResolver([packageDirectory]));
       }
     }
     sourceFactory = new SourceFactory(resolvers);
     context = AnalysisEngine.instance.createAnalysisContext();
     context.sourceFactory = sourceFactory;
+    // Uncomment the following to have errors reported on stdout and stderr
+//    AnalysisEngine.instance.logger = new StdLogger();

[jwren, 2014/03/11 23:53:37]

Do we want an additional --verbose flag to enable this for everyone?

[Brian Wilkerson, 2014/03/12 13:19:18]

I would probably call it "--debug", but it seems like a good idea. I probably
wouldn't document it though.

[jwren, 2014/03/12 16:28:44]

Will add the flag in a follow up CL.

 
     // set options for context
     AnalysisOptionsImpl contextOptions = new AnalysisOptionsImpl();
     contextOptions.cacheSize = _MAX_CACHE_SIZE;
     contextOptions.hint = !options.disableHints;
     context.analysisOptions = contextOptions;
 
     // Create and add a ChangeSet
     ChangeSet changeSet = new ChangeSet();
     changeSet.addedSource(source);
@@ skipping 81 matching lines @@
         var internalPath = pathos.join(libraryDirectory, '_internal') + pathos.separator;
         if (!filePath.startsWith(internalPath)) {
           return UriKind.DART_URI;
         }
       }
     }
     // some generic file
     return UriKind.FILE_URI;
   }
 }
+
+/**
+ * This [Logger] prints out information comments to [stdout] and error messages
+ * to [stderr].
+ */
+class StdLogger extends Logger {
+  
+  @override
+  void logError(String message) {
+    stderr.writeln(message);
+  }
+
+  @override
+  void logError2(String message, Exception exception) {
+    stderr.writeln(message);
+  }
+
+  @override
+  void logInformation(String message) {
+    stdout.writeln(message);
+  }
+
+  @override
+  void logInformation2(String message, Exception exception) {
+    stdout.writeln(message);
+  }
+}