Constrain constant references from deferred libraries

Constrain constant references from deferred libraries

Now any reference to a constant from a deferred library in a constant context will give an static error.

Also fixed the const-new expression constraint so it works with named constructors.

Split the deferred_constraints_test into deferred_constraints_type_annotation_test and deferred_constraints_constants_test

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33734

[floitsch, 2014-03-12 16:48:13]

LGTM.

https://codereview.chromium.org/195983006/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
(right):

https://codereview.chromium.org/195983006/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:424: if
(send.receiver is Send) {
Can't you just do a loop here?
while (send.receiver is Send) {
  send = send.receiver;
}

This should basically cover all prefix cases.

https://codereview.chromium.org/195983006/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/195983006/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/warnings.dart:557: "Deferred values
cannot be used as compile-time constants.");
A deferred value ... constant.

(singular).

https://codereview.chromium.org/195983006/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/warnings.dart:560: const
MessageKind("Deferred classes cannot be used to create "
ditto.

https://codereview.chromium.org/195983006/diff/60001/tests/language/deferred_...
File tests/language/deferred_constraints_constants_test.dart (right):

https://codereview.chromium.org/195983006/diff/60001/tests/language/deferred_...
tests/language/deferred_constraints_constants_test.dart:16: void f1({a: const
lib.Const()}) {} /// default_argument1: compile-time error
Try to reduce the coverage of the "///". If this line was missing a parenthesis
you wouldn't see it.

void f1({
  a: const lib.Const(),  /// default_argument1: compile-time error
  b: 499
}) {}

or maybe even:

void f1({ a: 
  const lib.Const()  /// default_argument1: compile-time error
  /*                 /// default_argument1: continued
  499
  */                 /// default_argument1: continued
}) {}

https://codereview.chromium.org/195983006/diff/60001/tests/language/deferred_...
tests/language/deferred_constraints_constants_test.dart:19: @lib.Const() class
H1 {} /// metadata1: compile-time error
@lib.Const()  /// metadata1: compile-time error
class H1 {}


This way you can leave the new H1() below.

[sigurdm, 2014-03-17 09:13:44]

Committed patchset #2 manually as r33734 (presubmit successful).